From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4GEBNLTr2WRuQAAAWB0awg (envelope-from ) for ; Mon, 14 Aug 2023 04:54:12 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=VAudkdBo; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C78F31E0C2; Mon, 14 Aug 2023 04:54:12 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B4F301E098 for ; Mon, 14 Aug 2023 04:54:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AAEA13858C31 for ; Mon, 14 Aug 2023 08:54:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AAEA13858C31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692003249; bh=C4uYPrvNAf3TfI3lF5Zh90EGOfD+l2CLTN+kESIuDoA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=VAudkdBoRJyGVmXwR4eevMsuLr9MADxVp3XKb5t7kkRH6YavAcOft8JeEUjjznhFI z6bQch6KLZsWiD1mWK6j+W6yHhr5LxTeYm7C196035Ee2wz4bOc0aHSAsDZzaVsolv 3KQPEfkyUgU64v9FVJjxnXhBKS2RyTWx+sdEgLLo= Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 4D0E83858D39 for ; Mon, 14 Aug 2023 08:53:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D0E83858D39 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 21F432189D for ; Mon, 14 Aug 2023 08:53:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 010D8138E2 for ; Mon, 14 Aug 2023 08:53:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8HWpOprr2WRJXAAAMHmgww (envelope-from ) for ; Mon, 14 Aug 2023 08:53:46 +0000 To: gdb-patches@sourceware.org Subject: [PATCH] [gdb] Fix maint print symbols/psymbols help text Date: Mon, 14 Aug 2023 10:53:40 +0200 Message-Id: <20230814085340.4066-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Consider the help text of "maint print symbols": ... (gdb) help maint print symbols Print dump of current symbol definitions. Usage: mt print symbols [-pc ADDRESS] [--] [OUTFILE] mt print symbols [-objfile OBJFILE] [-source SOURCE] [--] [OUTFILE] Entries in the full symbol table are dumped to file OUTFILE, or the terminal if OUTFILE is unspecified. If ADDRESS is provided, dump only the file for that address. If SOURCE is provided, dump only that file's symbols. If OBJFILE is provided, dump only that file's minimal symbols. ... and "maint print psymbols": ... (gdb) help maint print psymbols Print dump of current partial symbol definitions. Usage: mt print psymbols [-objfile OBJFILE] [-pc ADDRESS] [--] [OUTFILE] mt print psymbols [-objfile OBJFILE] [-source SOURCE] [--] [OUTFILE] Entries in the partial symbol table are dumped to file OUTFILE, or the terminal if OUTFILE is unspecified. If ADDRESS is provided, dump only the file for that address. If SOURCE is provided, dump only that file's symbols. If OBJFILE is provided, dump only that file's minimal symbols. ... The OBJFILE lines mistakingly mention minimal symbols. Fix this by reformulating as "dump only that object file's symbols". Tested on x86_64-linux. --- gdb/psymtab.c | 2 +- gdb/symmisc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/psymtab.c b/gdb/psymtab.c index 64b67078641..bdae9db9676 100644 --- a/gdb/psymtab.c +++ b/gdb/psymtab.c @@ -1687,7 +1687,7 @@ Entries in the partial symbol table are dumped to file OUTFILE,\n\ or the terminal if OUTFILE is unspecified.\n\ If ADDRESS is provided, dump only the file for that address.\n\ If SOURCE is provided, dump only that file's symbols.\n\ -If OBJFILE is provided, dump only that file's minimal symbols."), +If OBJFILE is provided, dump only that object file's symbols."), &maintenanceprintlist); add_cmd ("psymtabs", class_maintenance, maintenance_info_psymtabs, _("\ diff --git a/gdb/symmisc.c b/gdb/symmisc.c index a65552aa2d2..5b8a82e5137 100644 --- a/gdb/symmisc.c +++ b/gdb/symmisc.c @@ -1052,7 +1052,7 @@ Entries in the full symbol table are dumped to file OUTFILE,\n\ or the terminal if OUTFILE is unspecified.\n\ If ADDRESS is provided, dump only the file for that address.\n\ If SOURCE is provided, dump only that file's symbols.\n\ -If OBJFILE is provided, dump only that file's minimal symbols."), +If OBJFILE is provided, dump only that object file's symbols."), &maintenanceprintlist); add_cmd ("msymbols", class_maintenance, maintenance_print_msymbols, _("\ base-commit: 3b23a5ea693deee60648c9a9e9d666d83549298e -- 2.35.3