From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id c4gZABvHx2SuyDMAWB0awg (envelope-from ) for ; Mon, 31 Jul 2023 10:37:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=rSLJFU2J; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E60601E0C0; Mon, 31 Jul 2023 10:37:14 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C0E9E1E092 for ; Mon, 31 Jul 2023 10:37:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C4A9438582BE for ; Mon, 31 Jul 2023 14:37:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C4A9438582BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690814231; bh=MHcCjYwvoc+dqe6KEw9ryepT9VZplnGGMI7XWjhO8lU=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=rSLJFU2JtxusDYTszbWbI1Abj+d7cQhUEq9mGAPPGzo9kf9VMTZktYLZVuJ1T0CRN +xfRwJ3LdBlXbaz4+eS/7pwMrOrLi6OTyR0bIaN6msFSiXU5XCNJI7UdmTLJFU1BVQ gphjPD6Mwsl9jo/IhHpsYGcTXJ+XXqSuMiuWVa7A= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 9E12D3858C53 for ; Mon, 31 Jul 2023 14:36:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E12D3858C53 Received: from octopus (unknown [IPv6:2a02:390:9086:0:e1fd:bb76:ac43:b119]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 0DEC580AB2; Mon, 31 Jul 2023 14:36:51 +0000 (UTC) Date: Mon, 31 Jul 2023 15:36:24 +0100 To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Rename private member of FrameDecorator Message-ID: <20230731143624.f53cvywa6niuq7k5@octopus> References: <20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com> <20230725-dap-bt-path-v1-1-bb015b0d8e54@adacore.com> <20230728145046.waxsfe2w2yhklkfa@octopus> <87cz08gnma.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87cz08gnma.fsf@tromey.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Mon, 31 Jul 2023 14:36:51 +0000 (UTC) X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, Jul 31, 2023 at 08:30:05AM -0600, Tom Tromey wrote: > >>>>> "Lancelot" == Lancelot SIX writes: > > Lancelot> I do not object to this change, I am just noting that nothing is really > Lancelot> private in Python, and it seems to me that the commit message promises > Lancelot> otherwise. > > I've reworded it to: > > In Python, a member name starting with "__" is specially handled to > make it "more private" to the class -- it isn't truly private, but it > is renamed to make it less likely to be reused by mistake. > > Tom Hi, FWIW, this looks good to me. Best, Lancelot.