Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [pushed] [gdb/testsuite] Fix gdb.dwarf2/forward-spec.exp with read1
Date: Sat, 15 Jul 2023 10:11:04 +0200	[thread overview]
Message-ID: <20230715081104.2452-1-tdevries@suse.de> (raw)

When running test-case gdb.dwarf2/forward-spec.exp with check-read1 we run
into:
...
    parent:     ((cooked_index_entry *) 0xFAIL: <exp>: v has a parent
7fdc1c002ed0) [ns]^M
...

The problem is using regexps containing '.' to avoid escaping, which makes
them too generic.

Fix this by eliminating the '.' from the regexps.

Tested on x86_64-linux.
---
 gdb/testsuite/gdb.dwarf2/forward-spec.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/forward-spec.exp b/gdb/testsuite/gdb.dwarf2/forward-spec.exp
index ac7d16b09b8..f4512cf9b8c 100644
--- a/gdb/testsuite/gdb.dwarf2/forward-spec.exp
+++ b/gdb/testsuite/gdb.dwarf2/forward-spec.exp
@@ -74,7 +74,7 @@ if {[prepare_for_testing "failed to prepare" ${testfile} \
 
 set in_v 0
 gdb_test_multiple "maint print objfiles" "v has a parent" {
-    -re "^ *\\\[\[0-9\]\\\] *..cooked_index_entry\[^\r\n\]*" {
+    -re "^ *\\\[\[0-9\]\\\] *\\(\\(cooked_index_entry\[^\r\n\]*" {
 	set in_v 0
 	exp_continue
     }
@@ -82,7 +82,7 @@ gdb_test_multiple "maint print objfiles" "v has a parent" {
 	set in_v 1
 	exp_continue
     }
-    -re "^ *parent: *..cooked_index_entry .. (0|$hex)." {
+    -re "^ *parent: *\\(\\(cooked_index_entry \\*\\) (0|$hex)\\)" {
 	if {$in_v} {
 	    if {$expect_out(1,string) == "0"} {
 		fail $gdb_test_name

base-commit: c1f6762ce51fbcffb7ee3fdb1d794435fb19d43c
-- 
2.35.3


             reply	other threads:[~2023-07-15  8:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15  8:11 Tom de Vries via Gdb-patches [this message]
2023-07-15  8:46 ` Andreas Schwab
2023-07-15 15:06   ` Tom de Vries via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230715081104.2452-1-tdevries@suse.de \
    --to=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox