From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH v3 1/6] Minor cleanups in py-inferior.exp
Date: Thu, 13 Jul 2023 08:05:26 -0600 [thread overview]
Message-ID: <20230713-py-inf-fixes-30615-v3-1-26a024f30553@adacore.com> (raw)
In-Reply-To: <20230713-py-inf-fixes-30615-v3-0-26a024f30553@adacore.com>
While working on this series, I noticed a some oddities in
py-inferior.exp. One is an obviously incorrect comment, and the
others are confusing test names. This patch fixes these.
---
gdb/testsuite/gdb.python/py-inferior.exp | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/gdb.python/py-inferior.exp b/gdb/testsuite/gdb.python/py-inferior.exp
index 58deece5d5f..576c2b716e6 100644
--- a/gdb/testsuite/gdb.python/py-inferior.exp
+++ b/gdb/testsuite/gdb.python/py-inferior.exp
@@ -206,8 +206,7 @@ if [isnative] {
}
}
-# Test Inferior is_valid. This must always be the last test in
-# this testcase as it kills the inferior.
+# Test Inferior is_valid.
with_test_prefix "is_valid" {
gdb_py_test_silent_cmd "python inf_list = gdb.inferiors()" "get initial list" 1
@@ -247,7 +246,7 @@ with_test_prefix "is_valid" {
gdb_test "python print (inf_list\[1\].is_valid())" "True" \
"check inferior validity 3"
- gdb_test_no_output "remove-inferiors 2" "remove-inferiors 3"
+ gdb_test_no_output "remove-inferiors 2"
gdb_test "python print (inf_list\[0\].is_valid())" "True" \
"check inferior validity 4"
@@ -318,7 +317,7 @@ with_test_prefix "selected_inferior" {
"print a connection object"
gdb_test "inferior 1" ".*" "switch back to first inferior"
- gdb_test_no_output "remove-inferiors 3" "remove second inferior"
+ gdb_test_no_output "remove-inferiors 3"
}
# Test repr()/str()
--
2.40.1
next prev parent reply other threads:[~2023-07-13 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 14:05 [PATCH v3 0/6] Fix some Python Inferior methods Tom Tromey via Gdb-patches
2023-07-13 14:05 ` Tom Tromey via Gdb-patches [this message]
2023-07-13 14:05 ` [PATCH v3 2/6] Refactor py-inferior.exp Tom Tromey via Gdb-patches
2023-07-13 14:05 ` [PATCH v3 3/6] Rename Python variable in py-inferior.exp Tom Tromey via Gdb-patches
2023-07-13 14:05 ` [PATCH v3 4/6] Remove obsolete comment from gdbthread.h Tom Tromey via Gdb-patches
2023-07-13 14:05 ` [PATCH v3 5/6] Introduce scoped_restore_current_inferior_for_memory Tom Tromey via Gdb-patches
2023-07-13 14:05 ` [PATCH v3 6/6] Use correct inferior in Inferior.read_memory et al Tom Tromey via Gdb-patches
2023-07-14 16:56 ` Pedro Alves
2023-07-14 17:05 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713-py-inf-fixes-30615-v3-1-26a024f30553@adacore.com \
--to=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox