From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iO3NOUgdpmQtXxcAWB0awg (envelope-from ) for ; Wed, 05 Jul 2023 21:47:52 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=IQzYe16O; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E83831E0BD; Wed, 5 Jul 2023 21:47:52 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D041E1E0AC for ; Wed, 5 Jul 2023 21:47:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 026A13856944 for ; Thu, 6 Jul 2023 01:47:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 026A13856944 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688608070; bh=JI+TEs1d6CQaotzQZz8UQHUwZ78chZYhSQyFTTq1OEM=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IQzYe16OU/bsU1JY4m3DdNGzMEE4hRXO/ZtDLveIC5SH2VXunkJw0B+MXkKpo1IxU BjQW7C+jIw98oM2JLGGmpT+Ip7y4HfFu/R3V43E0VQS60xmhaiUhNY77IZTe+iXz67 SY+c+YKZdgiupWUcy2yvXuWJrRp4Hh1VpaRnLgK0= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 205B63858D20 for ; Thu, 6 Jul 2023 01:47:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 205B63858D20 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-130-dvtrFVUUNwOpUhgw9E0m0w-1; Wed, 05 Jul 2023 21:46:46 -0400 X-MC-Unique: dvtrFVUUNwOpUhgw9E0m0w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1EE283811F2B; Thu, 6 Jul 2023 01:46:46 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.9.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16A8BF5CE6; Thu, 6 Jul 2023 01:46:44 +0000 (UTC) Date: Wed, 5 Jul 2023 18:46:43 -0700 To: Bruno Larsen Cc: gdb-patches@sourceware.org, Andrew Burgess , pedro@palves.net, brobecker@adacore.com, simon.marchi@polymtl.ca, tom@tromey.com, tdevries@suse.de, ulrich.weigand@de.ibm.com, eliz@gnu.org Subject: Re: [PATCH v3 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Message-ID: <20230705184643.7bc66d07@f37-zws-nv> In-Reply-To: <78b12209-4837-bdd5-8ed0-6bab200b8555@redhat.com> References: <20230628124205.1604307-2-blarsen@redhat.com> <20230628124205.1604307-3-blarsen@redhat.com> <878rbxm07o.fsf@redhat.com> <78b12209-4837-bdd5-8ed0-6bab200b8555@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, 4 Jul 2023 17:08:47 +0200 Bruno Larsen wrote: > On 03/07/2023 18:25, Andrew Burgess wrote: > >> + - Tested-by: > >> + > >> + Used when a contributor has tested the patch and finds that it > >> + fixes the claimed problem. It may also be used to indicate that > >> + the contributor has performed regression testing. By itself, this > >> + tag says nothing about the quality of the fix implemented by the > >> + patch. > > Given the number of different ways that tests can be run, and that you > > specifically say "It_may_ also be used to indicate ...", I wonder if > > it's worth extending the last sentence to specifically say: > > > > By itself, this tag says nothing about the quality of the fix > > implemented by the patch, nor the amount of testing that was actually > > performed. > > > > Some people might give a (tb) tag just for running the tests added by > > the commit in question, while others might run the full testsuite on a > > unix board, while others might do a full regression test using multiple > > different boards. The tag itself tells us very little really. > > > I'm not opposed to making this document somewhat prescriptive. If you > think (and folks agree, of course) that as the tag is describe it tells > us TOO little, we could instead require that people do some level of > testing. My original idea would be that the person giving the tb tag > would at least run a full run of the testsuite on the default board, but > I changed it based on previous feedback. Or I can just add this change, > whichever you prefer I'm fine with Andrew's proposed wording. For a patch which is supposed to fix a bug, I'm most appreciative of testing which checks that the patch actually fixes the bug, especially if it's for a platform which I don't have easy access to. I know I've proposed a patch in the past saying that this should fix some problem, but don't know that for sure until someone with access to that platform applies the patch and does some testing. As for regression testing, my understanding is that the patch contributor should do this for at least one platform. If a tester does regression testing for his or her favorite oddball platform, that's also very much appreciated. Kevin