Re: [PATCH v3 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS

Kevin Buettner via Gdb-patches
2023-07-06T01:47:52Z

On Tue, 4 Jul 2023 17:08:47 +0200
Bruno Larsen <blarsen@redhat.com> wrote:

> On 03/07/2023 18:25, Andrew Burgess wrote:
> >> + - Tested-by:
> >> +
> >> + Used when a contributor has tested the patch and finds that it
> >> + fixes the claimed problem. It may also be used to indicate that
> >> + the contributor has performed regression testing. By itself, this
> >> + tag says nothing about the quality of the fix implemented by the
> >> + patch.
> > Given the number of different ways that tests can be run, and that you
> > specifically say "It_may_ also be used to indicate ...", I wonder if
> > it's worth extending the last sentence to specifically say:
> >
> > By itself, this tag says nothing about the quality of the fix
> > implemented by the patch, nor the amount of testing that was actually
> > performed.
> >
> > Some people might give a (tb) tag just for running the tests added by
> > the commit in question, while others might run the full testsuite on a
> > unix board, while others might do a full regression test using multiple
> > different boards. The tag itself tells us very little really.
> >
> I'm not opposed to making this document somewhat prescriptive. If you
> think (and folks agree, of course) that as the tag is describe it tells
> us TOO little, we could instead require that people do some level of
> testing. My original idea would be that the person giving the tb tag
> would at least run a full run of the testsuite on the default board, but
> I changed it based on previous feedback. Or I can just add this change,
> whichever you prefer

I'm fine with Andrew's proposed wording.

For a patch which is supposed to fix a bug, I'm most appreciative of
testing which checks that the patch actually fixes the bug, especially
if it's for a platform which I don't have easy access to. I know I've
proposed a patch in the past saying that this should fix some problem,
but don't know that for sure until someone with access to that
platform applies the patch and does some testing.

As for regression testing, my understanding is that the patch
contributor should do this for at least one platform. If a tester
does regression testing for his or her favorite oddball platform,
that's also very much appreciated.

Kevin