Re: [PATCH] [patch] gdbserver assert error on arm platform

[Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>]

I have some formatting nits as well as a request for a test case.  See
below...

On Thu, 11 May 2023 14:20:01 +0800
<zhiyong.yan@windriver.com> wrote:

> From: Zhiyong Yan <zhiyong.yan@windriver.com>
> 
> Bugzilla 30387 has given the steps of producing this issue on arm platform.
> Gdb should not assume pending threads always generate ___a non-gdbserver trap event___, a ___Signal 17___ event could happen.
> Now that resume_stopped_resumed_lwps() -> may_hw_step() assumes that the break point must already exist, resume_one_thread() should ensure the software breaking point is installed although the thread is pending.

In addition to the provided patch, could you also add a test case?

> 
> LINK: https://sourceware.org/bugzilla/show_bug.cgi?id=30387

s/LINK/Bug/

> 
> Signed-off-by: Zhiyong Yan zhiyong.yan@windriver.com
> ---
>  gdbserver/linux-low.cc | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
> index e6a39202a98..543daf66376 100644
> --- a/gdbserver/linux-low.cc
> +++ b/gdbserver/linux-low.cc
> @@ -4670,8 +4670,16 @@ linux_process_target::resume_one_thread (thread_info *thread,
>  
>        proceed_one_lwp (thread, NULL);
>      }
> -  else
> -    threads_debug_printf ("leaving LWP %ld stopped", lwpid_of (thread));
> +  else{
> +	threads_debug_printf ("leaving LWP %ld stopped", lwpid_of (thread));
> +	if(thread->last_resume_kind == resume_step){

Missing space before left paren and after right paren.

> +	    /*
> +	    * If resume_step is required by GDB, install single-step breakpoint.
> +	    */

Format the above comment as:

/* If resume_step is required by GDB, install single-step breakpoint.  */

If you want to use a block comment, don't prefix each line with a '*'. Also,
the trailing '*/' should be placed at the end of the last line in the block
comment.  Likewise for the leading '/*'.

> +	    if (supports_software_single_step())

Missing space before '()'.

> +	       install_software_single_step_breakpoints (lwp);
> +	}
> +  }
>  
>    thread->last_status.set_ignore ();
>    lwp->resume = NULL;
> -- 
> 2.25.1
>