From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4EKwCW/vS2R3wDgAWB0awg (envelope-from ) for ; Fri, 28 Apr 2023 12:08:15 -0400 Received: by simark.ca (Postfix, from userid 112) id 1B02C1E221; Fri, 28 Apr 2023 12:08:15 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=gQS3eykY; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 89A871E128 for ; Fri, 28 Apr 2023 12:08:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56434385770B for ; Fri, 28 Apr 2023 16:08:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56434385770B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682698088; bh=VpWQpr7iPP+qPrHqBqKleDsycMPrDQtQxKjk1ieY2UM=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gQS3eykYCWIEfpKyytoShCYV9Y3bA3StwiwCiS4SvQC7OllX9+3mCEGUVDY5ckXLC CQ6Jf/CqRGlEuU3MPbnwY0I/XCA1HBT+9zTE2hClLJTd+9Jhog38JnMbnTzuSAzOK6 5c4H6yGfxqre9ACMHtDO76Q1aIiSI9d0fv6jW35k= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1663F3858C74 for ; Fri, 28 Apr 2023 16:07:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1663F3858C74 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-362-xRhAgHL6PgeFZCTo_x4Vbw-1; Fri, 28 Apr 2023 12:07:42 -0400 X-MC-Unique: xRhAgHL6PgeFZCTo_x4Vbw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 97B843C025CB; Fri, 28 Apr 2023 16:07:41 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.10.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B5FF4043AC4; Fri, 28 Apr 2023 16:07:41 +0000 (UTC) Date: Fri, 28 Apr 2023 09:07:39 -0700 To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Do not change type in get_discrete_low_bound Message-ID: <20230428090739.4928deb1@f37-zws-nv> In-Reply-To: <20230427193515.1060101-1-tromey@adacore.com> References: <20230427193515.1060101-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 27 Apr 2023 13:35:15 -0600 Tom Tromey via Gdb-patches wrote: > get_discrete_low_bound has this code: > > /* Set unsigned indicator if warranted. */ > if (low >= 0) > type->set_is_unsigned (true); > > It's bad to modify a type in a getter like this, so this patch removes > this code. FWIW I looked and this code has been there since at least > 1999 (it was in the initial sourceware import). LGTM. Reviewed-by: Kevin Buettner