From: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] gdb: boolify 'should_print_thread'
Date: Tue, 4 Apr 2023 21:12:22 +0200 [thread overview]
Message-ID: <20230404191222.3408219-1-tankut.baris.aktemur@intel.com> (raw)
Convert the return type of 'should_print_thread' from int to bool.
---
gdb/thread.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/thread.c b/gdb/thread.c
index 25d97cd6072..5d5298331bf 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -986,7 +986,7 @@ pc_in_thread_step_range (CORE_ADDR pc, struct thread_info *thread)
and PID is not -1, then the thread is printed if it belongs to the
specified process. Otherwise, an error is raised. */
-static int
+static bool
should_print_thread (const char *requested_threads, int default_inf_num,
int global_ids, int pid, struct thread_info *thr)
{
@@ -1000,20 +1000,20 @@ should_print_thread (const char *requested_threads, int default_inf_num,
in_list = tid_is_in_list (requested_threads, default_inf_num,
thr->inf->num, thr->per_inf_num);
if (!in_list)
- return 0;
+ return false;
}
if (pid != -1 && thr->ptid.pid () != pid)
{
if (requested_threads != NULL && *requested_threads != '\0')
error (_("Requested thread not found in requested process"));
- return 0;
+ return false;
}
if (thr->state == THREAD_EXITED)
- return 0;
+ return false;
- return 1;
+ return true;
}
/* Return the string to display in "info threads"'s "Target Id"
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next reply other threads:[~2023-04-04 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 19:12 Tankut Baris Aktemur via Gdb-patches [this message]
2023-04-04 19:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404191222.3408219-1-tankut.baris.aktemur@intel.com \
--to=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox