From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NiCwCiC3KGSuViAAWB0awg (envelope-from ) for ; Sat, 01 Apr 2023 18:58:40 -0400 Received: by simark.ca (Postfix, from userid 112) id 1FD0C1E15D; Sat, 1 Apr 2023 18:58:40 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=QWgbxwz8; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A98E81E110 for ; Sat, 1 Apr 2023 18:58:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E8879385841A for ; Sat, 1 Apr 2023 22:58:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8879385841A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680389917; bh=ULyixiIDgcEdp4nMakxpMvfvg6K75xdVjdGWM0NUKd0=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=QWgbxwz8wd9o/ND5Do594UCOfCM871IKdV3BGO3GRs2XPiul/aH0zMHZx6r3x6GEw AcRGD36sVaBuGv1uYL082D6MeItsTGFy43fpzKVPx7+EbQTtqhtPquEwX3TT3GPu42 E992SKnqCwKWgxUFXRBDDyG169toABWpbyjkmaiU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F2F7F3858D35 for ; Sat, 1 Apr 2023 22:58:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2F7F3858D35 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-b8BCM5OQPKm-JgiB7kUXIw-1; Sat, 01 Apr 2023 18:58:17 -0400 X-MC-Unique: b8BCM5OQPKm-JgiB7kUXIw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADE10185A790; Sat, 1 Apr 2023 22:58:16 +0000 (UTC) Received: from f37-zws-nv (unknown [10.2.16.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B57A140EBF4; Sat, 1 Apr 2023 22:58:16 +0000 (UTC) Date: Sat, 1 Apr 2023 15:58:14 -0700 To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: remove unused parameters in print_doc_of_command, apropos_cmd Message-ID: <20230401155814.26541d6d@f37-zws-nv> In-Reply-To: <20230401193240.1619282-1-simon.marchi@polymtl.ca> References: <20230401193240.1619282-1-simon.marchi@polymtl.ca> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Sat, 1 Apr 2023 15:32:40 -0400 Simon Marchi via Gdb-patches wrote: > I noticed the prefix parameter was unused in print_doc_of_command. And > when removing it, it becomes unused in apropos_cmd. > > Sending as non-obvious, in case somebody can spot if this is a mistake, > and it should actually be used. Looks reasonable to me... Kevin