From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wSRKCPicHGSzrBcAWB0awg (envelope-from ) for ; Thu, 23 Mar 2023 14:39:52 -0400 Received: by simark.ca (Postfix, from userid 112) id 0B59F1E223; Thu, 23 Mar 2023 14:39:52 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=LkqJgZUV; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 92DDB1E0D3 for ; Thu, 23 Mar 2023 14:39:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2BEF83850204 for ; Thu, 23 Mar 2023 18:39:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2BEF83850204 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679596790; bh=tFyEwbdH9Ljox1Rd11zgttD2A7tUK3fUWnFPVa9wLFI=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LkqJgZUVBTNx3x1PLtdNvsCmLZ2KhfNdpR/wylhg9pFcOmsnMoACjkLi/UURVZE57 antdeEroRLkpmzvb/EljUh1CNrdopE8I1qvhhRco/8P48f/ego7L7uyBfyFQ7Rh/DX 9C7b7vpS0eUahuQMeOcPvqbCry7dxgZ8LAHstbZI= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DAADD3858CDB for ; Thu, 23 Mar 2023 18:39:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAADD3858CDB Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-168-0lSmO47fPXqX-I98tKteeQ-1; Thu, 23 Mar 2023 14:39:29 -0400 X-MC-Unique: 0lSmO47fPXqX-I98tKteeQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1D9A855300; Thu, 23 Mar 2023 18:39:28 +0000 (UTC) Received: from f37-zws-nv (unknown [10.2.16.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E84C1121314; Thu, 23 Mar 2023 18:39:28 +0000 (UTC) Date: Thu, 23 Mar 2023 11:39:27 -0700 To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH, v2] aarch64: Check for valid inferior thread/regcache before reading pauth registers Message-ID: <20230323113927.466085b3@f37-zws-nv> In-Reply-To: References: <20230316103904.1947447-1-luis.machado@arm.com> <20230323105619.9151-1-luis.machado@arm.com> <20230323112551.66e4da4f@f37-zws-nv> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 23 Mar 2023 18:32:31 +0000 Luis Machado wrote: > On 3/23/23 18:27, Luis Machado wrote: > > On 3/23/23 18:25, Kevin Buettner wrote: > >> On Thu, 23 Mar 2023 10:56:19 +0000 > >> Luis Machado via Gdb-patches wrote: > >> > >>> Changes in v2: > >>> > >>> - Dropped helper functions and used inferior_ptid/current_inferior () > >>> instead.__ Changes are now aarch64-specific. > >> > >> A bug which your patch fixes had been reported in Fedora bugzilla; see: > >> > >> https://bugzilla.redhat.com/show_bug.cgi?id=2177655 > >> > >> I made a scratch build using your v1 patch and one user reported the > >> bug fixed. > >> > >> I've looked over your v2 patch and it looks good to me. > > > > Thanks for testing. Andrew B. had pinged me about a report on his end. > > > > Hopefully we can get this sorted out soon, as it is quite annoying. > > > >> > >> Kevin > >> > > > > Worth mentioning that I plan to backport this fix to GDB 13.1, which might require a > slightly different patch because in GDB 13 this code is linux-specific instead of > OS-independent. In order to apply your v1 patch to (Fedora) GDB 13.1, I first cherry-picked commit 6d0020873de. I think it might make sense to do the same for the 13.1 branch. Kevin