Re: [PATCH v6 3/3] gdb/gcore: interrupt all threads to generate core in non-stop targets

Lancelot SIX via Gdb-patches
2023-03-22T17:00:12Z

Hi Eli,

>>
>> +If the current inferior's target is non-stop, @value{GDBN} ensures that
>
> Please add a cross-reference after "non-stop" to where we describe
> that mode.

I have done the change locally. This part of the patch is now:

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 6c811b8be2e..00949b4b950 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -13763,6 +13763,12 @@ Produce a core dump of the inferior process.
The optional argument
specified, the file name defaults to @file{core.@var{pid}}, where
@var{pid} is the inferior process ID.

+If the current inferior's target is non-stop (@pxref{Non-Stop Mode}),
+@value{GDBN} ensures that all the inferior's threads are stopped while
+generating the core dump. @value{GDBN} stops every running threads of
+the inferior before generating the core dump and resumes them when the
+command is done.
+
Note that this command is implemented only for some systems (as of
this writing, @sc{gnu}/Linux, FreeBSD, Solaris, and S390).

Best,
Lancelot.

>
> Thanks.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>