From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id f5tNGOfnFGQnoRIAWB0awg (envelope-from ) for ; Fri, 17 Mar 2023 18:21:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 56AD21E223; Fri, 17 Mar 2023 18:21:27 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xqQrKCII; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0102A1E0D3 for ; Fri, 17 Mar 2023 18:21:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62414385085C for ; Fri, 17 Mar 2023 22:21:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62414385085C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679091685; bh=o9a2NLhBlhhoZqiQfw0oNs+2361iUxjvLOa3frmp+OM=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xqQrKCIIE2Vidxgy2PO9HjYo6YgzMdURmtvuz1kGFmfNqUIupiDzWu8T9IU/HUIvd Eff94jc3r34PM4b+ExUyXHOuwZvI7CF3WmLDlnrDBAuxjRiRWMYd7BmDccMJdqQl0h I51K9csEDvAdL1vt2rNe3JbuNxRRCo5agcs6J8vY= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D23E63858C50 for ; Fri, 17 Mar 2023 22:21:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D23E63858C50 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-456-ZdiL7U-wOeWFXQlymSvcyQ-1; Fri, 17 Mar 2023 18:21:01 -0400 X-MC-Unique: ZdiL7U-wOeWFXQlymSvcyQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19C4A3C0E440; Fri, 17 Mar 2023 22:21:01 +0000 (UTC) Received: from f37-zws-nv (unknown [10.2.16.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93675492B00; Fri, 17 Mar 2023 22:21:00 +0000 (UTC) Date: Fri, 17 Mar 2023 15:20:59 -0700 To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Make ui_out::do_progress_end 'private' Message-ID: <20230317152059.0f8b4c52@f37-zws-nv> In-Reply-To: <20230316193741.3804125-1-tromey@adacore.com> References: <20230316193741.3804125-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 16 Mar 2023 13:37:41 -0600 Tom Tromey via Gdb-patches wrote: > I noticed that ui_out::do_progress_end is public, just to support one > use in debuginfod-support.c. This patch makes it private, updates > progress_info to call it from its destructor, and finally changes > debuginfod-support.c to follow. > --- > gdb/debuginfod-support.c | 101 ++++++++++++++++++++++----------------- > gdb/ui-out.h | 8 ++-- > 2 files changed, 61 insertions(+), 48 deletions(-) LGTM. Kevin