From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XO+VM5G/C2TnVwsAWB0awg (envelope-from ) for ; Fri, 10 Mar 2023 18:38:57 -0500 Received: by simark.ca (Postfix, from userid 112) id BF7281E223; Fri, 10 Mar 2023 18:38:57 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=AYKFWg52; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 36E2B1E0D3 for ; Fri, 10 Mar 2023 18:38:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9869D385842B for ; Fri, 10 Mar 2023 23:38:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9869D385842B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678491535; bh=7Y1ya91d5EuUvh825xFwCpuYnE8oWHn+opcI1KE1xFI=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AYKFWg52kORIxct8IaIDGug5Nu55e9/A3wdnoogZ4XsU9tQ1fYEHBr1ta1sBbW7te skPVQ7qBYxBoWyAnx8jdmp3qQpNx5OYYytL7zvcuN/ZJVcXmSZ0Uqhgp9p2ccQMqOI ebUdSx7r51Xf/gyUZofilLqF0rE3U5XFysEYC5wQ= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 02AF9385840D for ; Fri, 10 Mar 2023 23:38:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02AF9385840D Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-350--ih03qqAMD-CKrIF5cue_g-1; Fri, 10 Mar 2023 18:38:31 -0500 X-MC-Unique: -ih03qqAMD-CKrIF5cue_g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5158E2A59548; Fri, 10 Mar 2023 23:38:31 +0000 (UTC) Received: from f37-zws-nv (unknown [10.2.16.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B76F52166B26; Fri, 10 Mar 2023 23:38:30 +0000 (UTC) Date: Fri, 10 Mar 2023 16:38:29 -0700 To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Remove dead code from scalar_binop Message-ID: <20230310163829.076728ac@f37-zws-nv> In-Reply-To: <20230301212708.4030388-1-tromey@adacore.com> References: <20230301212708.4030388-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Wed, 1 Mar 2023 14:27:08 -0700 Tom Tromey via Gdb-patches wrote: > scalar_binop has code for "&&" and "||", but I think this code can't > currently be run -- and, furthermore, it doesn't make sense to have > this code here, as the point of these operators is to short-circuit > evaluation. Agreed, on both points. (Though it took me a while to convince myself that it couldn't currently be run.) Approved-by: Kevin Buettner