From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OatSOXWQv2N6CxUAWB0awg (envelope-from ) for ; Wed, 11 Jan 2023 23:45:41 -0500 Received: by simark.ca (Postfix, from userid 112) id DD26F1E128; Wed, 11 Jan 2023 23:45:41 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=XXYHL32k; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 903491E110 for ; Wed, 11 Jan 2023 23:45:41 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 15CCF385B517 for ; Thu, 12 Jan 2023 04:45:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15CCF385B517 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673498741; bh=IJvia0yvahtRLmS2C6fnduT1iftiLbW8nfX1bPIQ4p4=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=XXYHL32kgObyFpLjCpsRaP0lbhumdBW82VzABb1nZ1jqVQtzoMnvCo/Nh8XZVlZrP vPPNns0gU5BjRw4/S6jPqeXJHEPSol7mw16tQRrtTtlxTByt9tIp5nlXQqsJuc9ZHK ZiUPBwRRDOFzxLqkFs6gbkHsrQtCBr8z3yBIKyLU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B52E23858D35 for ; Thu, 12 Jan 2023 04:45:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B52E23858D35 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-_KW48k-8OBeSw7_DPMIXzA-1; Wed, 11 Jan 2023 23:45:17 -0500 X-MC-Unique: _KW48k-8OBeSw7_DPMIXzA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4055C3811F3D; Thu, 12 Jan 2023 04:45:17 +0000 (UTC) Received: from f37-zws-1 (unknown [10.2.17.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E977B140EBF5; Thu, 12 Jan 2023 04:45:16 +0000 (UTC) Date: Wed, 11 Jan 2023 21:45:15 -0700 To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 00/79] Rewrite "require" test procedure and use it more often Message-ID: <20230111214515.73c0d4e6@f37-zws-1> In-Reply-To: <20230112030052.3306113-1-tom@tromey.com> References: <20230112030052.3306113-1-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" I've looked at each patch in this series, but only skimmed the ones with obviously mechanical changes. I did look more closely at the parts (in later patches) which changed testsuite/lib/gdb.exp. In addition to the nits that I found regarding the "Use require skip_..." commits, the same nits apply to the "Use require use_gdb_stub" and "Use require gdb_debug_enable" commits. E.g. for the "Use require use_gdb_stub" commit, the message says: This changes some tests to use "require use_gdb_stub". ...but the actual require statements are all of the form: require !use_gdb_stub I like the use of "gdb --configuration" for determining whether GDB has certain features (e.g. tui, guile, python). Aside from the nits mentioned above, LGTM. Kevin