From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id X2fFBKDPtWP+WA8AWB0awg (envelope-from ) for ; Wed, 04 Jan 2023 14:12:32 -0500 Received: by simark.ca (Postfix, from userid 112) id 086381E222; Wed, 4 Jan 2023 14:12:32 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=I88Y9PLX; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B623F1E112 for ; Wed, 4 Jan 2023 14:12:31 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 566803858C30 for ; Wed, 4 Jan 2023 19:12:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 566803858C30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672859551; bh=igq4oZDJm1Ip2vqvRZnpr0qH5hfG6hXF44xaxShE4fE=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=I88Y9PLXqe/UXuSIhbAopKtOJcYdIis4bKxFBIJt2E9vrCw2rh0c+l8YBF24GOcQk KJ/5FZJZqW+tbkeCc2yk6t6WlQd3WsK008Is59JQ4dNuwJvpxL9x/OWymXOAB/c7c6 T36/jlK1VBDfEtHcBfCCu9ogc2Fzud34rELTurj4= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id 6BA833858D35 for ; Wed, 4 Jan 2023 19:12:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BA833858D35 Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::146]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id A72B7807EF; Wed, 4 Jan 2023 19:12:09 +0000 (UTC) Date: Wed, 4 Jan 2023 19:12:05 +0000 To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint Message-ID: <20230104191205.ajjcvx7vq3hmm424@ubuntu.lan> References: <20230103192216.108444-1-simon.marchi@polymtl.ca> <20230104091559.rqo2774ba566j5sg@ubuntu.lan> <9b050608-4bb6-dbc3-69f6-ebc9ad2cc303@polymtl.ca> <20230104161817.qbvbspsqcqrjw6w2@ubuntu.lan> <7d38d82e-1beb-c3dc-441a-b4e455351020@polymtl.ca> <20230104174038.aeau2an7tmufa3pj@ubuntu.lan> <20230104180248.4bumo5mm4vvpjx6c@ubuntu.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Wed, 04 Jan 2023 19:12:09 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Wed, Jan 04, 2023 at 02:05:23PM -0500, Simon Marchi wrote: > > > On 1/4/23 13:02, Lancelot SIX wrote: > > Something like this should fix the issue:. > > > > From 25585cc98812c90f819d78742243299a933ac879 Mon Sep 17 00:00:00 2001 > > From: Lancelot SIX > > Date: Wed, 4 Jan 2023 17:58:08 +0000 > > Subject: [PATCH] gdb: ensure test_name is initialized in gdb_breakpoint > > > > A refactoring in 4b9728bec15 (gdb: use gdb_test_multiple in > > gdb_breakpoint) left the $test_name variable initialized. > > Woops, thanks for noticing and for the patch. > > initialized -> uninitialized (or undefined)? I went for undefined which is more appropriate. Pushed with this modification. Best, Lancelot. > > > > > This patch fixes this. > > --- > > gdb/testsuite/lib/gdb.exp | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > > index ba16b2ab315..e17eace4cb1 100644 > > --- a/gdb/testsuite/lib/gdb.exp > > +++ b/gdb/testsuite/lib/gdb.exp > > @@ -639,8 +639,9 @@ proc gdb_breakpoint { linespec args } { > > set print_pass 1 > > } > > > > + set test_name "gdb_breakpoint: set breakpoint at $linespec" > > # The first two regexps are what we get with -g, the third is without -g. > > - gdb_test_multiple "$break_command $linespec" "gdb_breakpoint: set breakpoint at $linespec" { > > + gdb_test_multiple "$break_command $linespec" $test_name { > > -re "$break_message \[0-9\]* at .*: file .*, line $decimal.\r\n$gdb_prompt $" {} > > -re "$break_message \[0-9\]*: file .*, line $decimal.\r\n$gdb_prompt $" {} > > -re "$break_message \[0-9\]* at .*$gdb_prompt $" {} > > -- > > 2.34.1 > > This LGTM, thanks: > > Approved-By: Simon Marchi > > Simon