From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PA0pLgCntWOfRw8AWB0awg (envelope-from ) for ; Wed, 04 Jan 2023 11:19:12 -0500 Received: by simark.ca (Postfix, from userid 112) id B1B6C1E223; Wed, 4 Jan 2023 11:19:12 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=XVyEbLYA; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D2DE1E15D for ; Wed, 4 Jan 2023 11:19:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF4B83858C3A for ; Wed, 4 Jan 2023 16:19:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF4B83858C3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672849151; bh=nPS0S7OveVdhrLsFB7h68asYNM+4KA5G/40+PFJ2K1w=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=XVyEbLYA9bQbWuOpOOX/tgkBYgPkGPs0G/wMVjYpvdr1xZ2ea+LOWaMYdAhIJyDSy 4NbwxqcNj5CTMGC8eMZ26249P8wDKPwXU70pynA+pS5R2GRfpM2YCnVjpaFN40+/NS uqxRM1fhnOVIVRqRbJ3XMjoewBruCbrE8sUSCPrU= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id DF89A3858D35 for ; Wed, 4 Jan 2023 16:18:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF89A3858D35 Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::146]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id D30C48018A; Wed, 4 Jan 2023 16:18:50 +0000 (UTC) Date: Wed, 4 Jan 2023 16:18:44 +0000 To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint Message-ID: <20230104161817.qbvbspsqcqrjw6w2@ubuntu.lan> References: <20230103192216.108444-1-simon.marchi@polymtl.ca> <20230104091559.rqo2774ba566j5sg@ubuntu.lan> <9b050608-4bb6-dbc3-69f6-ebc9ad2cc303@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b050608-4bb6-dbc3-69f6-ebc9ad2cc303@polymtl.ca> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Wed, 04 Jan 2023 16:18:50 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Oh, right, I missed that. I folded the test name in the > gdb_test_multiple call (removed the test_name var) and used > $gdb_test_name in the fail call. I updated the patch locally. Should I > add your Reviewed-By after those changes? > > Simon > Yes, with those change, feel free to add Reviewed-By: Lancelot Six Best, Lancelot.