From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3TS7OYdYj2OAECEAWB0awg (envelope-from ) for ; Tue, 06 Dec 2022 09:58:15 -0500 Received: by simark.ca (Postfix, from userid 112) id DD73C1E124; Tue, 6 Dec 2022 09:58:15 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=jt9A7NFE; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 983DD1E112 for ; Tue, 6 Dec 2022 09:58:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D7DA38B636B for ; Tue, 6 Dec 2022 14:58:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D7DA38B636B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670338694; bh=mMw8WMe7n3fsBLiqaBhj8FEzi+qbcgN3RJooCKKhsyo=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=jt9A7NFEeFvrHtQhX96TdW9WxIS0r70phwrfA9swdVFWtLQ7XAMmAW+AJyUCLDigq y10+HnJxGKEfvB5qxqEf5i25vvU7shqfDD8Za4cKlbnVVzheL/b2httPfCEYeBh/YC NrYlU4NHQidVQdQjaFJiFvlDEEfuSHxUiKVHOYm4= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id AD858395B476 for ; Tue, 6 Dec 2022 14:52:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD858395B476 Received: from octopus (unknown [IPv6:2a02:390:9086:0:edc6:ce5e:38d6:84f9]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id ED88F806B1; Tue, 6 Dec 2022 14:52:11 +0000 (UTC) Date: Tue, 6 Dec 2022 14:52:02 +0000 To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [pushed] gdb: make frame_register static Message-ID: <20221206145202.lah7uwybcvv4akqi@octopus> References: <20221201183249.1062823-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221201183249.1062823-1-simon.marchi@efficios.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Tue, 06 Dec 2022 14:52:12 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Simon, The function frame_register is used outside of frame.c in the rocgdb downstream port. Do you think we could revert this patch here? Otherwise, this can be a change we keep downstream. Best, Lancelot. On Thu, Dec 01, 2022 at 01:32:49PM -0500, Simon Marchi via Gdb-patches wrote: > From: Simon Marchi > > It is only used inside frame.c. > > Change-Id: I44eb46a5992412f8f8b4954b2284b0ef3b549504 > --- > gdb/frame.c | 7 ++++++- > gdb/frame.h | 11 ----------- > 2 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/gdb/frame.c b/gdb/frame.c > index c8c4ec817a42..b4079ef833e8 100644 > --- a/gdb/frame.c > +++ b/gdb/frame.c > @@ -1166,7 +1166,12 @@ frame_register_unwind (frame_info_ptr next_frame, int regnum, > release_value (value); > } > > -void > +/* Get the value of the register that belongs to this FRAME. This > + function is a wrapper to the call sequence ``frame_register_unwind > + (get_next_frame (FRAME))''. As per frame_register_unwind(), if > + VALUEP is NULL, the registers value is not fetched/computed. */ > + > +static void > frame_register (frame_info_ptr frame, int regnum, > int *optimizedp, int *unavailablep, enum lval_type *lvalp, > CORE_ADDR *addrp, int *realnump, gdb_byte *bufferp) > diff --git a/gdb/frame.h b/gdb/frame.h > index 6b841fd50636..100ab1fe48eb 100644 > --- a/gdb/frame.h > +++ b/gdb/frame.h > @@ -511,17 +511,6 @@ extern ULONGEST get_frame_register_unsigned (frame_info_ptr frame, > extern bool read_frame_register_unsigned (frame_info_ptr frame, > int regnum, ULONGEST *val); > > -/* Get the value of the register that belongs to this FRAME. This > - function is a wrapper to the call sequence ``frame_register_unwind > - (get_next_frame (FRAME))''. As per frame_register_unwind(), if > - VALUEP is NULL, the registers value is not fetched/computed. */ > - > -extern void frame_register (frame_info_ptr frame, int regnum, > - int *optimizedp, int *unavailablep, > - enum lval_type *lvalp, > - CORE_ADDR *addrp, int *realnump, > - gdb_byte *valuep); > - > /* The reverse. Store a register value relative to the specified > frame. Note: this call makes the frame's state undefined. The > register and frame caches must be flushed. */ > -- > 2.38.1 >