From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iHGDLRrWiGOrCB8AWB0awg (envelope-from ) for ; Thu, 01 Dec 2022 11:28:10 -0500 Received: by simark.ca (Postfix, from userid 112) id B7EC31E124; Thu, 1 Dec 2022 11:28:10 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=cm0zZqIl; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D0EA1E0D3 for ; Thu, 1 Dec 2022 11:28:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1DFC13858C33 for ; Thu, 1 Dec 2022 16:28:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DFC13858C33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669912090; bh=YwuFH34aNbitwD3JjW/CCjZOgFhbGpqykbm2bvimPV8=; h=Date:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cm0zZqIlzSQ2E6RomTn5kD1Gbme3/RGUphr0xG67I3YOycn+yV0gFvTNk+Gscy4P9 QXfCR02BeEk8rK96ES+82Aivp8k3sRUMiAAtKtPmyMMqlPu62e5hvDg+J8tVcLkLTy zzeL0hVQ4CaSyy/tOpy+P0I29CxIZyC753ttQK+0= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 952703858D35 for ; Thu, 1 Dec 2022 16:27:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 952703858D35 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-2dcxMOqEMPmMk5NEoVhNYw-1; Thu, 01 Dec 2022 11:27:46 -0500 X-MC-Unique: 2dcxMOqEMPmMk5NEoVhNYw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9C0191C004EB; Thu, 1 Dec 2022 16:27:46 +0000 (UTC) Received: from f35-zws-nvidia (unknown [10.2.17.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F3584B3FCD; Thu, 1 Dec 2022 16:27:46 +0000 (UTC) Date: Thu, 1 Dec 2022 09:27:42 -0700 To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb/dwarf: add some QUIT macros Message-ID: <20221201092742.70e5e920@f35-zws-nvidia> In-Reply-To: <20221201160144.1045410-1-simon.marchi@efficios.com> References: <20221201160144.1045410-1-simon.marchi@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 1 Dec 2022 11:01:44 -0500 Simon Marchi via Gdb-patches wrote: > While testing the fix for PR 29105, I noticed I couldn't ctrl-C my way > out of GDB expanding many symtabs. GDB was busy in a loop in > cooked_index_functions::expand_symtabs_matching. Add a QUIT there. I > also happened to see a spot in > cooked_index_functions::expand_matching_symbols where a QUIT would be > useful too, since we iterate over a potentially big number of index > entries and expand CUs in the loop. Add one there too. LGTM. Kevin