From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XV3WLWLGR2NgjAsAWB0awg (envelope-from ) for ; Thu, 13 Oct 2022 04:03:46 -0400 Received: by simark.ca (Postfix, from userid 112) id B00FD1E112; Thu, 13 Oct 2022 04:03:46 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=gusDN4XQ; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 633B61E0CB for ; Thu, 13 Oct 2022 04:03:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F396D3853820 for ; Thu, 13 Oct 2022 08:03:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F396D3853820 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665648226; bh=u1Fdbo3zOCz0rYCdgg8may6UegnLQNPsboIYy/kBT7Y=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=gusDN4XQxs61xyzbAYcy90BZEufZBjI6qNKKrHT66alWDGE/S1ieHeQy0jfGhJyGm T6VphYKry4fSPsBdbCkwUcZu6H+ku8hmOdblvwDT2wknAgQg1ZvLKpm4MSL4hSud3l N1C0peL/IzXZ5gOx/eb7RUkPOtDzSoIq+yE3+uys= Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id D2A073858404 for ; Thu, 13 Oct 2022 08:03:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2A073858404 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A4C71F38A for ; Thu, 13 Oct 2022 08:03:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E7BDF13AAA for ; Thu, 13 Oct 2022 08:03:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vpSnNk3GR2P0WgAAMHmgww (envelope-from ) for ; Thu, 13 Oct 2022 08:03:25 +0000 Date: Thu, 13 Oct 2022 10:03:24 +0200 To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix gdb.dwarf2/entry-value-typedef.exp with -m32 Message-ID: <20221013080322.GA8133@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, With test-case gdb.dwarf2/entry-value-typedef.exp and target board unix/-m32, I run into: ... builtin_spawn -ignore SIGHUP g++ -fno-stack-protector \ gdb/testsuite/gdb.dwarf2/entry-value-typedef-amd64.S \ -fdiagnostics-color=never -Lbuild/libiberty -lm -m32 \ -o outputs/gdb.dwarf2/entry-value-typedef/entry-value-typedef^M entry-value-typedef.cpp: Assembler messages:^M entry-value-typedef.cpp:38: Error: bad register name `%rbp'^M ... The problem is that the test-cases selects an amd64 .S file based on the check: ... if { [istarget "x86_64-*-linux*"] } { ... which is also true for target board unix/-m32 on x86_64-linux. Fix this by adding the missing is_lp64_target check. Tested on x86_64-linux, using native and target board unix/-m32. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix gdb.dwarf2/entry-value-typedef.exp with -m32 --- gdb/testsuite/gdb.dwarf2/entry-value-typedef.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.dwarf2/entry-value-typedef.exp b/gdb/testsuite/gdb.dwarf2/entry-value-typedef.exp index db09cd2915d..6f196b71dc8 100644 --- a/gdb/testsuite/gdb.dwarf2/entry-value-typedef.exp +++ b/gdb/testsuite/gdb.dwarf2/entry-value-typedef.exp @@ -16,7 +16,7 @@ # The program associated to this test case uncovered a bug in GDB (PR 29374) # where a typedef type was used before it was resolved. -if { [istarget "x86_64-*-linux*"] } { +if { [istarget "x86_64-*-linux*"] && [is_lp64_target] } { set suffix amd64 } elseif { [istarget "aarch64-*-linux*"] } { set suffix aarch64