From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6KgdAf+VRWOg6QkAWB0awg (envelope-from ) for ; Tue, 11 Oct 2022 12:12:47 -0400 Received: by simark.ca (Postfix, from userid 112) id 026F21E112; Tue, 11 Oct 2022 12:12:47 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=RIPVY7cp; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 093DA1E0CB for ; Tue, 11 Oct 2022 12:12:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6AC303857034 for ; Tue, 11 Oct 2022 16:12:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6AC303857034 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665504762; bh=pCAgki5QDsNlbqrRGbh5F3yUTV4gCwwLVpPm8La/JLE=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=RIPVY7cpKIww23TUYHWcEqnEBbYgVW6QIR5BD7doI6y7Zzkcv/Cea6fv3SxedyOWR zTDtYsC8AhttWOc3hqlVk2uYQ8MggpKM8gfeTE5C/duIwOLnTi0mYbqlhFVMlI9r0K eN3Y5X8ZtEMxop+mixWNaSyaYiBxSmncapDknFAM= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 26B463858D28 for ; Tue, 11 Oct 2022 16:12:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26B463858D28 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 41F7822D03 for ; Tue, 11 Oct 2022 16:12:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2773B13AAC for ; Tue, 11 Oct 2022 16:12:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RkNQCOWVRWO3agAAMHmgww (envelope-from ) for ; Tue, 11 Oct 2022 16:12:21 +0000 Date: Tue, 11 Oct 2022 18:12:19 +0200 To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix gdb.debuginfod/fetch_src_and_symbols.exp with native-gdbserver Message-ID: <20221011161217.GA1690@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, When running test-case gdb.debuginfod/fetch_src_and_symbols.exp with target board native-gdbserver, I get: ... Running gdb.debuginfod/fetch_src_and_symbols.exp ... ERROR: tcl error sourcing gdb.debuginfod/fetch_src_and_symbols.exp. ERROR: gdbserver does not support start without extended-remote while executing "error "gdbserver does not support $command without extended-remote"" (procedure "gdb_test_multiple" line 51) invoked from within "gdb_test_multiple $command $message {*}$opts $user_code" (procedure "gdb_test" line 56) invoked from within "gdb_test "start" "Temporary breakpoint.*"" ... Fix this by replacing gdb_test "start" with runto_main. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix gdb.debuginfod/fetch_src_and_symbols.exp with native-gdbserver --- gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp index d781d7a53c7..8bb9203686d 100644 --- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp +++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp @@ -158,7 +158,9 @@ proc_with_prefix no_url { } { # Generate a core file and test that GDB cannot find the # executable. clean_restart ${binfile}2 - gdb_test "start" "Temporary breakpoint.*" + if ![runto_main] { + return -1 + } gdb_test "generate-core-file $::corefile" "Saved corefile $::corefile" \ "file [file tail $::corefile] gen" file rename -force ${binfile}2 $debugdir