From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cXlMM/LDOmN1tAQAWB0awg (envelope-from ) for ; Mon, 03 Oct 2022 07:13:54 -0400 Received: by simark.ca (Postfix, from userid 112) id C11691E112; Mon, 3 Oct 2022 07:13:54 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=RenAggom; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6A4751E0CB for ; Mon, 3 Oct 2022 07:13:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 82EC338582BA for ; Mon, 3 Oct 2022 11:13:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82EC338582BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664795633; bh=rTCw+veyoMVHR2F901cZOfTvord/sq6Lt4FFglyjphg=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RenAggomSMremWSRf2s1ZH5e6pNVmkK0HubGD8qxhAkU8UIw1wy5BmZYs5jSER1j2 GFyjA8gYr9XHmIx4q/b3aF6DchGMiwcTVUvO9F9QQgaWC7DAEAKiIfhxppZ0lAUVIF IPPvr4wfBi16acqJp3ammojxGj4DiN4id12t4Zq0= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 5CF473858D32 for ; Mon, 3 Oct 2022 11:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5CF473858D32 Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id DEFBC80E98; Mon, 3 Oct 2022 11:13:31 +0000 (UTC) Date: Mon, 3 Oct 2022 12:12:54 +0100 To: Andrew Burgess Subject: Re: [PATCH 1/2] gdb/testsuite: avoid creating files in gdb/testsuite directory Message-ID: <20221003111213.rzfci537xl3xbfkw@octopus> References: <337887b9594348c5880b7adbc0850e72e319e857.1664721741.git.aburgess@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <337887b9594348c5880b7adbc0850e72e319e857.1664721741.git.aburgess@redhat.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Mon, 03 Oct 2022 11:13:32 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Andrew, On Sun, Oct 02, 2022 at 03:43:56PM +0100, Andrew Burgess via Gdb-patches wrote: > I spotted that the test gdb.dwarf2/dw2-using-debug-str.exp was > creating an output file (called debug_str_section) in the root > build/gdb/testsuite directory instead of using the > build/gdb/testsuite/output/gdb.dwarf2/dw2-using-debug-str/ directory. > > This is a result of not using standard_output_file in the test > script. > > With this commit the file is now placed in the expected output > directory. The test still passes for me. > --- > gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp b/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp > index d27554f2f89..729961c99b5 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp > @@ -105,7 +105,8 @@ gdb_test "p global_var" " = \\{aa = 0, bb = 0, cc = 0\\}" > # cc-with-dwz-m.exp and cc-with-gnu-debuglink.exp. Handle this by > # skipping the remainder of the test-case. > set debug_str_section "${binfile}-debug-str" > -set args "--dump-section .debug_str=debug_str_section $binfile" > +set debug_str_file [standard_output_file "debug_str_section"] > +set args "--dump-section .debug_str=${debug_str_file} $binfile" Just above your change, there is the following line: set debug_str_section "${binfile}-debug-str" I believe that the original intent was to use this as output file name, but the '$' was use in the set args line. It looks to me that the change should be: -set args "--dump-section .debug_str=debug_str_section $binfile" +set args "--dump-section .debug_str=$debug_str_section $binfile" If you prefer your change, the `set debug_str_section` line should be removed. Best, Lancelot. > set result [remote_exec host "[gdb_find_objcopy] $args"] > set status [lindex $result 0] > set output [lindex $result 1] > -- > 2.25.4 >