Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections

Fangrui Song via Gdb-patches
2022-09-24T07:14:04Z

On 2022-09-24, Enze Li wrote:
>Hi Fangrui,
>
>One nit, maybe not an important one.
>
>A proper committed message should include a link to the relevant bug on
>Bugzilla. Like this,
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29563
>
>For more detail, see here[1].
>
>[1] https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages
>
>Thanks,
>Enze

Hi Enze,

Thanks for the notice. I see that gdb started to use "Bug:" since 2021-07.

In binutils, there isn't such a convention and there is no commit using
"Bug:". So I will keep using the umbrella link PR29397.

I am on the
fence whether the gdb one needs to use "Bug:" but I'll probably not use
it this time. Ideally the gdb patch should be separate, but since the
bfd's zstd dependency needs gdb build system's cooperation it is placed
in the same patch:)

I am still waiting for an approval from binutils side. Relatedly, I
believe ChangeLog is no longer strictly enforced. There are many recent
commits don't using ChangeLog. I intentionally skip ChangeLog for this
patch since I believe it would provide little value. (I see
"ANNOUNCEMENT: ChangeLog policy change after GDB 11".)