From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WEWqITyuLmP9LT8AWB0awg (envelope-from ) for ; Sat, 24 Sep 2022 03:14:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 8764B1E112; Sat, 24 Sep 2022 03:14:04 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=DILgcDA1; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 41FCA1E0D3 for ; Sat, 24 Sep 2022 03:14:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C39B7385843E for ; Sat, 24 Sep 2022 07:14:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C39B7385843E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664003643; bh=iUwadJp5Rh9blxO/Io3yVEfCJVMX2OthfEspdYeW7qw=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DILgcDA1eiO6R3RWqGNOt0CgX9Kr5DLkz8iXQSMCTIuoEBTd3yXbPy0DszPLVltd8 9hmhJ6tK0WaOFI4w45RcDcGlCcsWkCmzNDI6lusOt08gnMI6l2sH1hWsfa21B/tKch tctOtkDC5MiALi3cM5eqJYDJjin5ynsI3ywQkLv4= Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 0D8EF385840B for ; Sat, 24 Sep 2022 07:13:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D8EF385840B Received: by mail-pj1-x102c.google.com with SMTP id rt12so1955635pjb.1 for ; Sat, 24 Sep 2022 00:13:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=iUwadJp5Rh9blxO/Io3yVEfCJVMX2OthfEspdYeW7qw=; b=2F8jJLasmlw8y/NdLcB9VYvy0sB4tyYCb8W/sQqzWPZPzPqkdYdKgNg3dH+52FDL3R Vz9/v9VqkSgYQXyFEnodpAmkTEUznWFXAIA+Hn9Zwz/BgBgGDpPVy1rd7RxmRU3ctLpG 04nAJ40THGqOhwISn113B2Qnnow3EjH5RcI6whY4PpeNMobUj3OzFmerLx0tfm/P9hge P4d1AclfFuX8s1hBDNB2aINxXL48kVLTt39PYtiULwvP4vEn1aJCTIbhYyJI75uWtAuH UhrxYdw6a19Dp1bJXE2AyD/hrdPJQr+szwzF1vvvz61D49OjAcuyyIB8W26KLSIzcH9v DaJQ== X-Gm-Message-State: ACrzQf1sTlx9RzXkOSiOtMPUBkQyFh3O7TuPrrdz+zMuTOy8ooMoq5D5 HO7rmGU1dnX+TPraRAf6PoaNmA== X-Google-Smtp-Source: AMsMyM7m97KVFKV/epX59axHLWkCBzMRh/9gGagaFAErmUblSF5BjBqP5WAbo2/98aSS/RfHTIUNMg== X-Received: by 2002:a17:90b:1c82:b0:1ee:eb41:b141 with SMTP id oo2-20020a17090b1c8200b001eeeb41b141mr14050002pjb.143.1664003621914; Sat, 24 Sep 2022 00:13:41 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:8ec5:9ef2:91c2:62b8]) by smtp.gmail.com with ESMTPSA id m15-20020a17090a2c0f00b001fb53587166sm2688932pjd.28.2022.09.24.00.13.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Sep 2022 00:13:40 -0700 (PDT) Date: Sat, 24 Sep 2022 00:13:37 -0700 To: Enze Li Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections Message-ID: <20220924071337.6shhf26p7vbqkcjj@google.com> References: <20220923040837.550160-1-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Fangrui Song via Gdb-patches Reply-To: Fangrui Song Cc: Nick Clifton , Alan Modra , binutils@sourceware.org, Jan Beulich , Fangrui Song via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-09-24, Enze Li wrote: >Hi Fangrui, > >One nit, maybe not an important one. > >A proper committed message should include a link to the relevant bug on >Bugzilla. Like this, > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29563 > >For more detail, see here[1]. > >[1] https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages > >Thanks, >Enze Hi Enze, Thanks for the notice. I see that gdb started to use "Bug:" since 2021-07. In binutils, there isn't such a convention and there is no commit using "Bug:". So I will keep using the umbrella link PR29397. I am on the fence whether the gdb one needs to use "Bug:" but I'll probably not use it this time. Ideally the gdb patch should be separate, but since the bfd's zstd dependency needs gdb build system's cooperation it is placed in the same patch:) I am still waiting for an approval from binutils side. Relatedly, I believe ChangeLog is no longer strictly enforced. There are many recent commits don't using ChangeLog. I intentionally skip ChangeLog for this patch since I believe it would provide little value. (I see "ANNOUNCEMENT: ChangeLog policy change after GDB 11".)