From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hNJeAzpuG2OPUDYAWB0awg (envelope-from ) for ; Fri, 09 Sep 2022 12:47:54 -0400 Received: by simark.ca (Postfix, from userid 112) id F0AA11E22A; Fri, 9 Sep 2022 12:47:53 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=PHtJ98fa; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7581F1E222 for ; Fri, 9 Sep 2022 12:47:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F1A033857432 for ; Fri, 9 Sep 2022 16:47:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F1A033857432 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662742073; bh=bai20ZOWM8IKu4dqxosj1akPaXjQvnuYAwtTtfsxPOU=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PHtJ98fahrG3KlhwIXCG7z/VZrIbhHtUBqwtOwxS0cluAl/JWDSybSvkTrQ9cIzIz bKyi6F+MQpXIeSAE+/uqRtWC5QCEKJ3oAz5+qakO1xXSe6A/kwi9hU81Gl8kUVM+XI /E2DBuByBWcx95tMPPaJ4lQ9ZKjJgsLgTu+JfctU= Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 766E73858429 for ; Fri, 9 Sep 2022 16:47:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 766E73858429 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A8C841F8AE for ; Fri, 9 Sep 2022 16:47:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 95E4113A93 for ; Fri, 9 Sep 2022 16:47:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kLNSIw1uG2PCCwAAMHmgww (envelope-from ) for ; Fri, 09 Sep 2022 16:47:09 +0000 Date: Fri, 9 Sep 2022 18:47:08 +0200 To: gdb-patches@sourceware.org Subject: [PATCH][gdb/symtab] Don't complain about function decls Message-ID: <20220909164706.GA22031@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, [ Requires "[gdb/symtab] Don't complain about inlined functions" as submitted here ( https://sourceware.org/pipermail/gdb-patches/2022-September/191762.html ). ] With the test-case included in this patch, we get: ... (gdb) ptype main^M During symbol reading: cannot get low and high bounds for subprogram DIE \ at 0xc1^M type = int (void)^M (gdb) FAIL: gdb.dwarf2/anon-ns-fn.exp: ptype main without complaints ... The DIE causing the complaint is a function declaration: ... <2>: Abbrev Number: 3 (DW_TAG_subprogram) DW_AT_name : foo DW_AT_declaration : 1 ... which is referred to from the DIE representing the function definition: ... <1>: Abbrev Number: 7 (DW_TAG_subprogram) DW_AT_specification: <0xc1> DW_AT_low_pc : 0x4004c7 <101> DW_AT_high_pc : 0x7 ... which does contain the low and high bounds. Fix this by not complaining about function declarations. Tested on x86_64-linux. Any comments? Thanks, - Tom [gdb/symtab] Don't complain about function decls --- gdb/dwarf2/read.c | 4 +++- gdb/testsuite/gdb.dwarf2/anon-ns-fn.cc | 31 +++++++++++++++++++++++++++++++ gdb/testsuite/gdb.dwarf2/anon-ns-fn.exp | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 67 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index a8a87e36ff0..9ccb07b71ea 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -12031,7 +12031,9 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu) && attr->is_nonnegative () && (attr->as_nonnegative () == DW_INL_inlined || attr->as_nonnegative () == DW_INL_declared_inlined)); - if (!external_p && !inlined_p) + attr = dwarf2_attr (die, DW_AT_declaration, cu); + bool decl_p = attr != nullptr && attr->as_boolean (); + if (!external_p && !inlined_p && !decl_p) complaint (_("cannot get low and high bounds " "for subprogram DIE at %s"), sect_offset_str (die->sect_off)); diff --git a/gdb/testsuite/gdb.dwarf2/anon-ns-fn.cc b/gdb/testsuite/gdb.dwarf2/anon-ns-fn.cc new file mode 100644 index 00000000000..62a650528c4 --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/anon-ns-fn.cc @@ -0,0 +1,31 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2022 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +namespace +{ + void + foo (void) + { + } +} + +int +main (void) +{ + foo (); + return 0; +} diff --git a/gdb/testsuite/gdb.dwarf2/anon-ns-fn.exp b/gdb/testsuite/gdb.dwarf2/anon-ns-fn.exp new file mode 100644 index 00000000000..71b1a477a39 --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/anon-ns-fn.exp @@ -0,0 +1,33 @@ +# Copyright 2022 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +if {[skip_cplus_tests]} { continue } + +standard_testfile .cc + +if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}] { + return -1 +} + +set cmd "ptype main" + +set re \ + [multi_line \ + $cmd \ + "type = int \\(void\\)"] + +with_complaints 5 { + gdb_test $cmd $re "$cmd without complaints" +}