From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bww4NGY4G2OmODYAWB0awg (envelope-from ) for ; Fri, 09 Sep 2022 08:58:14 -0400 Received: by simark.ca (Postfix, from userid 112) id C1B221E22A; Fri, 9 Sep 2022 08:58:14 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ewumNkHG; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C422C1E21F for ; Fri, 9 Sep 2022 08:58:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D2F933857359 for ; Fri, 9 Sep 2022 12:58:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2F933857359 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662728292; bh=9iIZX5Q45DC/gT6pQ46CYsO+45AKHvEziGlBr7VPjDM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ewumNkHG5WnTxRS7lLg5zHSZpDjxr3CK5CmIXIzAmDVo7oQvwRRNLu/lJMXw10GUf zmycKrU09mt3qwgpZBVnI1CcVgl4tI7iqVV7457JUpcvsuNnK4SphqlUo8VBVrYZ0G F2lGFIvRPFhzMODKV0X+omjuszI1kAAqZyA2pEuI= Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 39ED43857365 for ; Fri, 9 Sep 2022 12:57:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39ED43857365 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 490DF1F8DA for ; Fri, 9 Sep 2022 12:57:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2EA4A139D5 for ; Fri, 9 Sep 2022 12:57:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NxVJCkY4G2N5NwAAMHmgww (envelope-from ) for ; Fri, 09 Sep 2022 12:57:42 +0000 Date: Fri, 9 Sep 2022 14:57:40 +0200 To: gdb-patches@sourceware.org Subject: [PATCH][gdb/symtab] Don't complain about inlined functions Message-ID: <20220909125738.GA1363@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, With the test-case included in this patch, we get: ... (gdb) ptype main^M During symbol reading: cannot get low and high bounds for subprogram DIE \ at 0x113^M During symbol reading: cannot get low and high bounds for subprogram DIE \ at 0x11f^M type = int (void)^M (gdb) FAIL: gdb.dwarf2/inline.exp: ptype main ... The complaints are about foo, with DW_AT_inline == DW_INL_inlined: ... <1><11f>: Abbrev Number: 6 (DW_TAG_subprogram) <120> DW_AT_name : foo <126> DW_AT_prototyped : 1 <126> DW_AT_type : <0x10c> <12a> DW_AT_inline : 1 (inlined) ... and foo2, with DW_AT_inline == DW_INL_declared_inlined: ... <1><113>: Abbrev Number: 5 (DW_TAG_subprogram) <114> DW_AT_name : foo2 <11a> DW_AT_prototyped : 1 <11a> DW_AT_type : <0x10c> <11e> DW_AT_inline : 3 (declared as inline and inlined) ... Fix this by not complaining about inlined functions. Tested on x86_64-linux. Any comments? Thanks, - Tom [gdb/symtab] Don't complain about inlined functions --- gdb/dwarf2/read.c | 9 ++++++++- gdb/testsuite/gdb.dwarf2/inline.c | 34 ++++++++++++++++++++++++++++++++++ gdb/testsuite/gdb.dwarf2/inline.exp | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 74 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 3ca441c4cae..a8a87e36ff0 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -12024,7 +12024,14 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu) <= PC_BOUNDS_INVALID) { attr = dwarf2_attr (die, DW_AT_external, cu); - if (attr == nullptr || !attr->as_boolean ()) + bool external_p = attr != nullptr && attr->as_boolean (); + attr = dwarf2_attr (die, DW_AT_inline, cu); + bool inlined_p + = (attr != nullptr + && attr->is_nonnegative () + && (attr->as_nonnegative () == DW_INL_inlined + || attr->as_nonnegative () == DW_INL_declared_inlined)); + if (!external_p && !inlined_p) complaint (_("cannot get low and high bounds " "for subprogram DIE at %s"), sect_offset_str (die->sect_off)); diff --git a/gdb/testsuite/gdb.dwarf2/inline.c b/gdb/testsuite/gdb.dwarf2/inline.c new file mode 100644 index 00000000000..2e07f6c4a9d --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/inline.c @@ -0,0 +1,34 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2022 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +static int __attribute__((always_inline)) +foo (void) +{ + return 0; +} + +static int inline __attribute__((always_inline)) +foo2 (void) +{ + return 0; +} + +int +main (void) +{ + return foo () + foo2 (); +} diff --git a/gdb/testsuite/gdb.dwarf2/inline.exp b/gdb/testsuite/gdb.dwarf2/inline.exp new file mode 100644 index 00000000000..06182d877af --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/inline.exp @@ -0,0 +1,32 @@ +# Copyright 2022 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +standard_testfile .c + +if [prepare_for_testing "failed to prepare" $testfile $srcfile \ + {debug nowarnings}] { + return -1 +} + +set cmd "ptype main" + +set re \ + [multi_line \ + $cmd \ + "type = int \\(void\\)"] + +with_complaints 5 { + gdb_test $cmd $re "$cmd without complaints" +}