From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oD9HIrKuGGNIITUAWB0awg (envelope-from ) for ; Wed, 07 Sep 2022 10:46:10 -0400 Received: by simark.ca (Postfix, from userid 112) id 8023B1E4A7; Wed, 7 Sep 2022 10:46:10 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=pPOVwNnh; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A5CC31E21F for ; Wed, 7 Sep 2022 10:46:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 826B0385142A for ; Wed, 7 Sep 2022 14:46:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 826B0385142A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662561965; bh=9d7SeNcJNTWQvUBpZLAZbh506OjPsE+Ns8AWRumDFvU=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=pPOVwNnhmV8bUTJ9UixYiDD89JO+Ohb1U3uPguua/BJ/5Sr9V2DcAlZmD2jKqKo2B uRrvQjznkilrwRXUwKSF2JCMoKYVnzSTr5N1RrXdAr6H1qiERZvL6X9+NQqe2/EkD6 ctP6EYdR+uUXhDt/lw4GrD+4z3UncIJswfnvd2sc= Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C5FF83858403 for ; Wed, 7 Sep 2022 14:45:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C5FF83858403 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0D7D1204E0; Wed, 7 Sep 2022 14:45:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E9D7B13A66; Wed, 7 Sep 2022 14:45:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id l/DHN5auGGPtSgAAMHmgww (envelope-from ); Wed, 07 Sep 2022 14:45:42 +0000 Date: Wed, 7 Sep 2022 16:45:41 +0200 To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] xfail gdb.ada/O2_float_param.exp for aarch64 and gcc 7.5.0 Message-ID: <20220907144539.GA3288@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, On aarch64-linux, with gcc 7.5.0, we run into: ... (gdb) frame^M #0 callee.increment (val=99.0, val@entry=9.18340949e-41, msg=...) at \ callee.adb:21^M 21 if Val > 200.0 then^M (gdb) FAIL: gdb.ada/O2_float_param.exp: scenario=all: frame ... The problem is a GCC bug, filed as "PR98148 - [AArch64] Wrong location expression for function entry values" ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98148 ). Xfail the test for aarch64 and gcc 7. Tested on x86_64-linux and aarch64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29418 Any comments? Thanks, - Tom [gdb/testsuite] xfail gdb.ada/O2_float_param.exp for aarch64 and gcc 7.5.0 --- gdb/testsuite/gdb.ada/O2_float_param.exp | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.ada/O2_float_param.exp b/gdb/testsuite/gdb.ada/O2_float_param.exp index 0c2969e0c4f..062a27572f5 100644 --- a/gdb/testsuite/gdb.ada/O2_float_param.exp +++ b/gdb/testsuite/gdb.ada/O2_float_param.exp @@ -19,6 +19,13 @@ if { [skip_ada_tests] } { return -1 } standard_ada_testfile foo +set have_xfail 0 +if { [is_aarch64_target] } then { + if { [gcc_major_version] <= 8 } { + set have_xfail 1 + } +} + foreach_with_prefix scenario {all minimal} { set flags [list debug \ optimize=-O2 \ @@ -32,6 +39,21 @@ foreach_with_prefix scenario {all minimal} { runto "increment" - gdb_test "frame" \ + set re \ "#0\\s+callee\\.increment \\(val(=val@entry)?=99\\.0, msg=\\.\\.\\.\\).*" + set re_different_entry_val \ + "#0\\s+callee\\.increment \\(val=99.0, val@entry=.*, msg=\\.\\.\\.\\).*" + gdb_test_multiple "frame" "" { + -re -wrap $re { + pass $gdb_test_name + } + -re -wrap $re_different_entry_val { + if { $have_xfail } { + # GCC PR98148 + xfail $gdb_test_name + } else { + fail $gdb_test_name + } + } + } }