From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xbkJEDjrFWOswjMAWB0awg (envelope-from ) for ; Mon, 05 Sep 2022 08:27:36 -0400 Received: by simark.ca (Postfix, from userid 112) id 344B81E4A7; Mon, 5 Sep 2022 08:27:36 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=NDjx4Asy; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 93EE21E13B for ; Mon, 5 Sep 2022 08:27:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BDD7385695F for ; Mon, 5 Sep 2022 12:27:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BDD7385695F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662380852; bh=ibDzjUwmVTFJ1FwPumzbCthlmvlMYZWn1PxpWUva0rw=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NDjx4Asyyrauze2gp9rJNl8u1cnnqGu9YOOXx+PpPmPLuq530ivQmjHZXfNdkKPJH mBdv2kCFW9aWpmAAm0NERa5CKQWDVOdxaYf/6yelf+1fiEL6frdGb/MCU/jMp2PzMs WWQR8AxTlJzjUJFKkum/B/rIt6HxTOudz4mP7VQs= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 53F223858CDA for ; Mon, 5 Sep 2022 12:27:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 53F223858CDA Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E71575FC96 for ; Mon, 5 Sep 2022 12:27:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D360913A66 for ; Mon, 5 Sep 2022 12:27:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9sJkMhzrFWOfAgAAMHmgww (envelope-from ) for ; Mon, 05 Sep 2022 12:27:08 +0000 Date: Mon, 5 Sep 2022 14:27:07 +0200 To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Use prototype to call libc functions Message-ID: <20220905122706.GA23594@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, On openSUSE Tumbleweed (using glibc 2.36), I run into: ... (gdb) print /d (int) munmap (4198400, 4096)^M Invalid cast.^M (gdb) FAIL: gdb.base/break-main-file-remove-fail.exp: cmdline: \ get integer valueof "(int) munmap (4198400, 4096)" ... The problem is that after starting the executable, the symbol has type "void (*) (void)": ... (gdb) p munmap $1 = {} 0x401030 (gdb) start ... (gdb) p munmap $2 = {void (void)} 0x7ffff7feb9a0 <__GI_munmap> ... which causes the "Invalid cast" error. Looking at the debug info for glibc for symbol __GI_munmap: ... <0><189683>: Abbrev Number: 1 (DW_TAG_compile_unit) <189691> DW_AT_name : ../sysdeps/unix/syscall-template.S <189699> DW_AT_producer : GNU AS 2.39.0 <1><1896ae>: Abbrev Number: 2 (DW_TAG_subprogram) <1896af> DW_AT_name : __GI___munmap <1896b3> DW_AT_external : 1 <1896b4> DW_AT_low_pc : 0x10cad0 <1896bc> DW_AT_high_pc : 37 ... that's probably caused by this bit (or similar bits for other munmap aliases). This is fixed in gas on trunk by commit 5578fbf672e ("GAS: Add a return type tag to DWARF DIEs generated for function symbols"). Work around this (for say gas 2.39) by explicitly specifying the prototype for munmap. Likewise for getpid in a couple of other test-cases. Tested on x86_64-linux. Any comments? Thanks, - Tom [gdb/testsuite] Use prototype to call libc functions --- gdb/testsuite/gdb.base/break-main-file-remove-fail.exp | 4 +++- gdb/testsuite/gdb.base/dprintf-detach.exp | 2 +- gdb/testsuite/gdb.base/info-os.exp | 2 +- gdb/testsuite/gdb.threads/siginfo-threads.exp | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.base/break-main-file-remove-fail.exp b/gdb/testsuite/gdb.base/break-main-file-remove-fail.exp index 41c3114aa05..444b1d33ace 100644 --- a/gdb/testsuite/gdb.base/break-main-file-remove-fail.exp +++ b/gdb/testsuite/gdb.base/break-main-file-remove-fail.exp @@ -87,7 +87,9 @@ proc test_remove_bp { initial_load } { # should warn the user about it. set pagesize [get_integer_valueof "pg_size" 0] set align_addr [expr $bp_addr - $bp_addr % $pagesize] - set munmap [get_integer_valueof "(int) munmap ($align_addr, $pagesize)" -1] + set munmap_prototype "int (*) (void *, size_t)" + set munmap_expr "(($munmap_prototype) munmap) ($align_addr, $pagesize)" + set munmap [get_integer_valueof $munmap_expr -1] if {$munmap != 0} { unsupported "can't munmap foo's page" diff --git a/gdb/testsuite/gdb.base/dprintf-detach.exp b/gdb/testsuite/gdb.base/dprintf-detach.exp index 692048f82a3..b6da01a2845 100644 --- a/gdb/testsuite/gdb.base/dprintf-detach.exp +++ b/gdb/testsuite/gdb.base/dprintf-detach.exp @@ -52,7 +52,7 @@ proc dprintf_detach_test { breakpoint_always_inserted dprintf_style disconnected # Get PID of test program. set inferior_pid -1 set test "get inferior process ID" - gdb_test_multiple "call (int) getpid ()" $test { + gdb_test_multiple "call ((int (*) (void)) getpid) ()" $test { -re ".* = ($decimal).*$gdb_prompt $" { set inferior_pid $expect_out(1,string) pass $test diff --git a/gdb/testsuite/gdb.base/info-os.exp b/gdb/testsuite/gdb.base/info-os.exp index 7967e2e43df..d12f8750a9c 100644 --- a/gdb/testsuite/gdb.base/info-os.exp +++ b/gdb/testsuite/gdb.base/info-os.exp @@ -39,7 +39,7 @@ if ![runto_main] then { # Get PID of test program. set inferior_pid "" set test "get inferior process ID" -gdb_test_multiple "call (int) getpid()" $test { +gdb_test_multiple "call ((int (*) (void)) getpid) ()" $test { -re ".* = ($decimal).*$gdb_prompt $" { set inferior_pid $expect_out(1,string) pass $test diff --git a/gdb/testsuite/gdb.threads/siginfo-threads.exp b/gdb/testsuite/gdb.threads/siginfo-threads.exp index f10c7fdcd25..8dd34b753a2 100644 --- a/gdb/testsuite/gdb.threads/siginfo-threads.exp +++ b/gdb/testsuite/gdb.threads/siginfo-threads.exp @@ -41,7 +41,7 @@ gdb_breakpoint [gdb_get_line_number "break-at-exit"] set test "get pid" set pid "" -gdb_test_multiple "p (int) getpid ()" $test { +gdb_test_multiple "p ((int (*) (void))getpid) ()" $test { -re " = (\[0-9\]+)\r\n$gdb_prompt $" { set pid $expect_out(1,string) pass $test