From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bLzICKNnB2NoES0AWB0awg (envelope-from ) for ; Thu, 25 Aug 2022 08:14:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 16E451E4A7; Thu, 25 Aug 2022 08:14:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5E9DE1E21F for ; Thu, 25 Aug 2022 08:14:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1291385F026 for ; Thu, 25 Aug 2022 12:14:25 +0000 (GMT) Received: from lug-owl.de (lug-owl.de [IPv6:2a03:4000:10:469::]) by sourceware.org (Postfix) with ESMTPS id 8D19A3858D28 for ; Thu, 25 Aug 2022 12:14:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D19A3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de Received: by lug-owl.de (Postfix, from userid 1001) id 0C3854200B; Thu, 25 Aug 2022 14:14:11 +0200 (CEST) Date: Thu, 25 Aug 2022 14:14:11 +0200 From: Jan-Benedict Glaw To: gdb-patches@sourceware.org, Nick Clifton , Jim Wilson Subject: [PATCH] sim/aarch64: Fix type error in declaration Message-ID: <20220825121410.b27gxw7jzbenndbs@lug-owl.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xdo2rnhht6z7jd2i" Content-Disposition: inline X-Operating-System: Linux chamaeleon 5.14.0-0.bpo.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: NeoMutt/20170113 (1.7.2) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --xdo2rnhht6z7jd2i Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! While building with very recent GCC versions, I noticed these build issues for aarch64-{elf,linux-gnu,linux,rtems}: =2E../configure --prefix=3D/tmp/gdb-aarch64-elf --target=3Daarch64-elf [...] make V=3D1 all-gdb [...] /usr/lib/gcc-snapshot/bin/gcc -DHAVE_CONFIG_H -DWITH_HW=3D1 -DHAVE_DV_SO= CKSER -DDEFAULT_INLINE=3D0 -Wall -Wdeclaration-after-statement -Wpointer-ar= ith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subs= cripts -Wempty-body -Wunused-but-set-parameter -Wno-error=3Dmaybe-uninitial= ized -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statem= ent -Wmissing-parameter-type -Wpointer-sign -Wold-style-declaration -Werror= -I. -I/var/lib/laminar/run/gdb-aarch64-elf/1/binutils-gdb/sim/aarch64 -I.= =2E/common -I/var/lib/laminar/run/gdb-aarch64-elf/1/binutils-gdb/sim/aarch6= 4/../common -I../../include -I/var/lib/laminar/run/gdb-aarch64-elf/1/binuti= ls-gdb/sim/aarch64/../../include -I../../bfd -I/var/lib/laminar/run/gdb-aar= ch64-elf/1/binutils-gdb/sim/aarch64/../../bfd -I../../opcodes -I/var/lib/la= minar/run/gdb-aarch64-elf/1/binutils-gdb/sim/aarch64/../../opcodes -I../.. = -I/var/lib/laminar/run/gdb-aarch64-elf/1/binutils-gdb/sim/aarch64/../../gn= ulib/import -I../../gnulib/import -g -O2 -c -o cpustate.o -MT cpustate.o= -MMD -MP -MF .deps/cpustate.Tpo cpustate.c cpustate.c:270:1: error: conflicting types for 'aarch64_get_CPSR_bits' due = to enum/integer mismatch; have 'uint32_t(sim_cpu *, FlagMask)' {aka 'unsign= ed int(struct _sim_cpu *, FlagMask)'} [-Werror=3Denum-int-mismatch] 270 | aarch64_get_CPSR_bits (sim_cpu *cpu, FlagMask mask) | ^~~~~~~~~~~~~~~~~~~~~ In file included from sim-main.h:30, from cpustate.c:28: cpustate.h:310:20: note: previous declaration of 'aarch64_get_CPSR_bits' wi= th type 'uint32_t(sim_cpu *, uint32_t)' {aka 'unsigned int(struct _sim_cpu = *, unsigned int)'} 310 | extern uint32_t aarch64_get_CPSR_bits (sim_cpu *, uint32_t); | ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [Makefile:509: cpustate.o] Error 1 make[3]: Leaving directory '/var/lib/laminar/run/gdb-aarch64-elf/1/binutils= -gdb/sim/aarch64' make[2]: *** [Makefile:1929: all-recursive] Error 1 make[2]: Leaving directory '/var/lib/laminar/run/gdb-aarch64-elf/1/binutils= -gdb/sim' make[1]: *** [Makefile:1181: all] Error 2 make[1]: Leaving directory '/var/lib/laminar/run/gdb-aarch64-elf/1/binutils= -gdb/sim' make: *** [Makefile:11309: all-sim] Error 2 This fixes the declaration: diff --git a/sim/aarch64/cpustate.h b/sim/aarch64/cpustate.h index 1d25b3af15a..94e0bc80333 100644 --- a/sim/aarch64/cpustate.h +++ b/sim/aarch64/cpustate.h @@ -307,7 +307,7 @@ extern void aarch64_save_LR (sim_cpu *); /* Flag register accessors. */ extern uint32_t aarch64_get_CPSR (sim_cpu *); extern void aarch64_set_CPSR (sim_cpu *, uint32_t); -extern uint32_t aarch64_get_CPSR_bits (sim_cpu *, uint32_t); +extern uint32_t aarch64_get_CPSR_bits (sim_cpu *, FlagMask); extern void aarch64_set_CPSR_bits (sim_cpu *, uint32_t, uint32_t); extern uint32_t aarch64_test_CPSR_bit (sim_cpu *, FlagMask); extern void aarch64_set_CPSR_bit (sim_cpu *, FlagMask); OK to install? Thanks, Jan-Benedict --=20 --xdo2rnhht6z7jd2i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCYwdnkAAKCRAdvV51g5nh u3lSAKCM9moVmmACrfIpcMTXkh8Jt7lPOwCfV7a5Nt/XiU0+NHuafzEOdl+5qrU= =uvf6 -----END PGP SIGNATURE----- --xdo2rnhht6z7jd2i--