From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iKPVF3FB8WKr3CIAWB0awg (envelope-from ) for ; Mon, 08 Aug 2022 13:01:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 5E2A61EA06; Mon, 8 Aug 2022 13:01:37 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=RvJFMOyU; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1410D1E9ED for ; Mon, 8 Aug 2022 13:01:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB4423857001 for ; Mon, 8 Aug 2022 17:01:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB4423857001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659978096; bh=gMchC3YUWVZOJ6uArdA+yBxc+qvQ7KEsYlRaAvj/CeY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=RvJFMOyUNtFNUnEL85y8NLw8MTvSNjxdnwxbA7p9BLRtuU497RkNcxUxXr+DYOWQM fMjbxErV0F/4gwsRvQlZ6tXYHinWLezZZTs+JdwZ68zsp0Rz09EoR4MHV4ab5O6QAt 3FrX2wnwzrmgf1I5DuDTzPJzJ1HkncsrsWyLbjB4= Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id 498DB3857375 for ; Mon, 8 Aug 2022 17:01:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 498DB3857375 X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="273692669" X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="273692669" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 10:01:16 -0700 X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="932137042" Received: from labpcdell3650-003.iul.intel.com (HELO localhost) ([172.28.49.87]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 10:01:14 -0700 To: gdb-patches@sourceware.org Subject: [PATCH v5 2/3] gdb, dwarf: add assert to dwarf2_get_pc_bounds Date: Mon, 8 Aug 2022 19:00:37 +0200 Message-Id: <20220808170038.86105-3-nils-christian.kempke@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Nils-Christian Kempke via Gdb-patches Reply-To: Nils-Christian Kempke Cc: jinisusan.george@amd.com, tom@tromey.com, aburgess@redhat.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" In dwarf2_get_pc_bounds we were writing unchecked to *lowpc. This commit adds a gdb_assert to first check that lowpc != nullptr. Signed-off-by: Nils-Christian Kempke --- gdb/dwarf2/read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 569a7867084..b869fa8058d 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -13140,6 +13140,7 @@ dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc, if (low == 0 && !per_objfile->per_bfd->has_section_at_zero) return PC_BOUNDS_INVALID; + gdb_assert (lowpc != nullptr); *lowpc = low; if (highpc != nullptr) *highpc = high; -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928