From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id e9zMFRvr42K3jxwAWB0awg (envelope-from ) for ; Fri, 29 Jul 2022 10:13:47 -0400 Received: by simark.ca (Postfix, from userid 112) id 487F01EA03; Fri, 29 Jul 2022 10:13:47 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=OSr0iux/; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EFA901E9E9 for ; Fri, 29 Jul 2022 10:13:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 76A523857BAC for ; Fri, 29 Jul 2022 14:13:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76A523857BAC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659104026; bh=xcDwUXILJkJ3iTR8+Lk2EfjVO3sJRJDRbunmmzNHhy8=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OSr0iux/v2vSkqXFVyCot/bIX/xDvKeMghdC2HbM28Os1Z+OdppVrFuWPijkbAh4N nyVeFNmOqaXq4HC1FvzmOD4fcDAvOTn3xveRYI7sErSlNZn1ydGSDu+w79NoAJ5Xnf EEt5Lu2qLYJwOnSst39JTCpLr6ymMeykaqQjJu04= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 8CA6C3858297 for ; Fri, 29 Jul 2022 14:13:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CA6C3858297 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BB4B434B70 for ; Fri, 29 Jul 2022 14:13:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A6D9E13A8E for ; Fri, 29 Jul 2022 14:13:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mQ6RJwXr42KaYAAAMHmgww (envelope-from ) for ; Fri, 29 Jul 2022 14:13:25 +0000 Date: Fri, 29 Jul 2022 16:13:24 +0200 To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix gdb.ada/convvar_comp.exp with broken debug info Message-ID: <20220729141322.GA32385@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, On aarch64-linux I run into this failure with gcc 7.5.0: ... (gdb) print $item.started^M $1 = (-5312, 65535, 4202476)^M (gdb) FAIL: gdb.ada/convvar_comp.exp: print $item.started ... The test-case expects (0, 0, 0), but we're getting another value due to incorrect location information. Work around this by: - first printing the value, and then - verifying that the convenience variable matches the printed value. I've verified that the test-case still checks what it should by disabling the fix from commit cc0e770c0d0 ("memory error printing component of record from convenience variable") and observing the test-case fail. Tested on x86_64-linux and aarch64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29420 Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix gdb.ada/convvar_comp.exp with broken debug info --- gdb/testsuite/gdb.ada/convvar_comp.exp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.ada/convvar_comp.exp b/gdb/testsuite/gdb.ada/convvar_comp.exp index ebc2659aeaa..1923bd785c7 100644 --- a/gdb/testsuite/gdb.ada/convvar_comp.exp +++ b/gdb/testsuite/gdb.ada/convvar_comp.exp @@ -30,7 +30,15 @@ if ![runto "break_me" ] then { return } +set val "" +gdb_test_multiple "print item.started" "" { + -re -wrap " = \\((.*)\\)" { + set val $expect_out(1,string) + pass $gdb_test_name + } +} + gdb_test_no_output "set variable \$item := item" gdb_test "print \$item.started" \ - " = \\(0, 0, 0\\)" + " = \\($val\\)"