From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9ulPFiGR4GL+JRsAWB0awg (envelope-from ) for ; Tue, 26 Jul 2022 21:13:05 -0400 Received: by simark.ca (Postfix, from userid 112) id 4796D1E9ED; Tue, 26 Jul 2022 21:13:05 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=OIcWUC+2; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8FE641E5EA for ; Tue, 26 Jul 2022 21:13:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1BA3F385800D for ; Wed, 27 Jul 2022 01:13:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1BA3F385800D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1658884384; bh=p/cK084NtHePk1pOeCwNG7ThvYviEPOOPajMUIvwJKI=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=OIcWUC+27OjeDxrbdS30xLXWNb9Zlu8Be0n3pwH84F1fVSfJn0lGaFe5kL9PbePTV rXa408jN52MNIlJDNXOL4MAteOJ/UBPfxP3JxvD6DIT8nCTq5Z2Eti+MHlTE9pWKMj +MnXzy+66U+m6+wPB0zajbUECIPNIbavAf7y5ugg= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 898373858422 for ; Wed, 27 Jul 2022 01:12:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 898373858422 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-i2MZfxLrPs2eWk5jiI3K6w-1; Tue, 26 Jul 2022 21:12:38 -0400 X-MC-Unique: i2MZfxLrPs2eWk5jiI3K6w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 707D33C0ED4D; Wed, 27 Jul 2022 01:12:38 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18D02141511F; Wed, 27 Jul 2022 01:12:37 +0000 (UTC) Date: Tue, 26 Jul 2022 18:12:36 -0700 To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new clang warning. Message-ID: <20220726181236.4958cd5d@f35-zws-1> In-Reply-To: <20220725113822.1855437-3-felix.willgerodt@intel.com> References: <20220725113822.1855437-1-felix.willgerodt@intel.com> <20220725113822.1855437-3-felix.willgerodt@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, 25 Jul 2022 13:38:22 +0200 Felix Willgerodt via Gdb-patches wrote: > Clang 15.0.0 added a new warning for deprecated non-prototype functions: > https://reviews.llvm.org/D122895 > Callfuncs.exp is impacted and won't run due to new warnings: > > callfuncs.c:339:5: warning: a function declaration without a prototype is > deprecated in all versions of C and is not supported in C2x > [-Wdeprecated-non-prototype] > int t_float_values (float_arg1, float_arg2) > > This patch disables those warnings with -Wno-deprecated-non-prototype. > Removing the test for deprecated syntax would also be an option. But I will > leave that up for others to decide. This approach seems reasonable to me. However, I think you should move at least some of the explanation provided above into a (new) comment just before the line added by your patch. > --- > gdb/testsuite/gdb.base/callfuncs.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp > index 4448cc127ba..d74357b8b48 100644 > --- a/gdb/testsuite/gdb.base/callfuncs.exp > +++ b/gdb/testsuite/gdb.base/callfuncs.exp > @@ -18,7 +18,7 @@ > > standard_testfile > > -set compile_flags {debug} > +set compile_flags {debug additional_flags=-Wno-deprecated-non-prototype} > if [support_complex_tests] { > lappend compile_flags "additional_flags=-DTEST_COMPLEX" > } > -- > 2.34.3 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >