From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4MUNLuSL4GJtIxsAWB0awg (envelope-from ) for ; Tue, 26 Jul 2022 20:50:44 -0400 Received: by simark.ca (Postfix, from userid 112) id AF2E91E9ED; Tue, 26 Jul 2022 20:50:44 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ZbB9QoXU; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0B52D1E5EA for ; Tue, 26 Jul 2022 20:50:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4FDB638582BC for ; Wed, 27 Jul 2022 00:50:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4FDB638582BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1658883043; bh=ByVs+AIiAJDPq4RC1B3oQ+NXwkFwjiQQ3r+4wXBo8Bo=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZbB9QoXU3vqokyXGqHgTNnIU/A+/ynruXCYGFONogxL3NmQiRlEymYz+2TUGVxXhe +wN90MNo/q4dw/kjwwahrjtvGPZnv76M2AoQciQOH2onA8xXS209yl1wILkedUfR2o ti6bBo7caVDZUENHGRwMafOV3YfrySMgIR5GSQGk= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3E0D3385841D for ; Wed, 27 Jul 2022 00:49:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E0D3385841D Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-543-ULJVz_mTMqi26TiDpDbstw-1; Tue, 26 Jul 2022 20:49:55 -0400 X-MC-Unique: ULJVz_mTMqi26TiDpDbstw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 56A47811E75; Wed, 27 Jul 2022 00:49:55 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E16D8492C3B; Wed, 27 Jul 2022 00:49:54 +0000 (UTC) Date: Tue, 26 Jul 2022 17:49:53 -0700 To: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb/csky support .reg2 for kernel 4.x and later Message-ID: <20220726174953.41da6c15@f35-zws-1> In-Reply-To: <20220725024459.21042-1-jiangshuai_li@linux.alibaba.com> References: <20220725024459.21042-1-jiangshuai_li@linux.alibaba.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: Jiangshuai Li Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, 25 Jul 2022 10:44:59 +0800 Jiangshuai Li via Gdb-patches wrote: > When kernel's version >= 4.x, the size of .reg2 section will be 400. > Contents of .reg2 are { > unsigned long vr[96]; // vr0~vr15 & fr16~fr31 > unsigned long fcr; > unsigned long fesr; > unsigned long fid; > unsigned long reserved; > }; > > --- > gdb/csky-linux-tdep.c | 150 +++++++++++++++++++++++++++++++++++++----- > 1 file changed, 134 insertions(+), 16 deletions(-) > > diff --git a/gdb/csky-linux-tdep.c b/gdb/csky-linux-tdep.c > index 440045e7713..aa85a299922 100644 > --- a/gdb/csky-linux-tdep.c > +++ b/gdb/csky-linux-tdep.c > @@ -36,6 +36,8 @@ > #define SIZEOF_CSKY_GREGSET 34*4 > /* Float regset fesr fsr fr0-fr31 for CK810. */ > #define SIZEOF_CSKY_FREGSET 34*4 > +/* Float regset vr0~vr15 fr15~fr31, reserved for CK810 when kernel 4.x. */ You might want to expand the comment above indicating that the struct layout can be found in a comment within csky_supply_fregset. > +#define SIZEOF_CSKY_FREGSET_K4X 400 > > /* Offset mapping table from core_section to regcache of general > registers for ck810. */ > @@ -118,15 +120,76 @@ csky_supply_fregset (const struct regset > *regset, int fregset_num = ARRAY_SIZE (csky_fregset_offset); > > gdb_assert (len >= SIZEOF_CSKY_FREGSET); > - for (i = 0; i < fregset_num; i++) > + if (len == SIZEOF_CSKY_FREGSET) > { > - if ((regnum == csky_fregset_offset[i] || regnum == -1) > - && csky_fregset_offset[i] != -1) > - { > - int num = csky_fregset_offset[i]; > - offset += register_size (gdbarch, num); > - regcache->raw_supply (csky_fregset_offset[i], fregs + > offset); > - } > + for (i = 0; i < fregset_num; i++) > + { > + if ((regnum == csky_fregset_offset[i] || regnum == -1) > + && csky_fregset_offset[i] != -1) > + { > + int num = csky_fregset_offset[i]; > + offset += register_size (gdbarch, num); > + regcache->raw_supply (csky_fregset_offset[i], fregs + > offset); > + } > + } > + } > + else if (len == SIZEOF_CSKY_FREGSET_K4X) > + { > + /* When kernel version >= 4.x, .reg2 size will be 400. > + Contents is { > + unsigned long vr[96]; // vr0~vr15 + fr16~fr31 > + unsigned long fcr; > + unsigned long fesr; > + unsigned long fid; > + unsigned long reserved; > + } */ > + int fcr_regno[] = {122, 123, 121}; /* fcr, fesr, fid. */ > + > + /* Supply vr0~vr15. */ > + for (i = 0; i < 16; i ++) > + { > + if (gdbarch_register_name (gdbarch, (CSKY_VR0_REGNUM + i))) > + { > + offset = 16 * i; > + regcache->raw_supply (CSKY_VR0_REGNUM + i, > + fregs + offset); > + } > + } > + /* Supply fr0~fr15. */ > + for (i = 0; i < 16; i ++) > + { > + if (gdbarch_register_name (gdbarch, (CSKY_FR0_REGNUM + i))) > + { > + offset = 16 * i; Are these offsets correct? I.e. do the fr0~fr15 registers use the same offsets as vr0~vr15? Also, not related to this patch, but while trying to figure this out, I found this line in csky-tdep.h - it looks fishy to me since it's way bigger than CSKY_MAX_REGS: CSKY_FR16_REGNUM = 1172, It definitely matters since you refer to CSKY_FR16_REGNUM below. > + regcache->raw_supply (CSKY_FR0_REGNUM + i, > + fregs + offset); > + } > + } > + /* Supply fr16~fr31. */ > + for (i = 0; i < 16; i ++) > + { > + if (gdbarch_register_name (gdbarch, (CSKY_FR16_REGNUM + > i))) > + { > + offset = (16 * 16) + (8 * i); > + regcache->raw_supply (CSKY_FR16_REGNUM + i, > + fregs + offset); > + } > + } > + /* Supply fcr, fesr, fid. */ > + for (i = 0; i < 3; i ++) > + { > + if (gdbarch_register_name (gdbarch, fcr_regno[i])) > + { > + offset = (16 * 16) + (16 * 8) + (4 * i); > + regcache->raw_supply (fcr_regno[i], > + fregs + offset); > + } > + } > + } > + else > + { > + warning (_("Unknow size %ld of section .reg2, can not get > value" > + " of float registers."), len); > } > } > > @@ -144,14 +207,66 @@ csky_collect_fregset (const struct regset > *regset, int offset = 0; > > gdb_assert (len >= SIZEOF_CSKY_FREGSET); > - for (regno = 0; regno < fregset_num; regno++) > + if (len == SIZEOF_CSKY_FREGSET) > + { > + for (regno = 0; regno < fregset_num; regno++) > + { > + if ((regnum == csky_fregset_offset[regno] || regnum == -1) > + && csky_fregset_offset[regno] != -1) > + { > + offset += register_size (gdbarch, > csky_fregset_offset[regno]); > + regcache->raw_collect (regno, fregs + offset); > + } > + } > + } > + else if (len == SIZEOF_CSKY_FREGSET_K4X) > + { > + /* When kernel version >= 4.x, .reg2 size will be 400. > + Contents is { > + unsigned long vr[96]; // vr0~vr15 + fr16~fr31 > + unsigned long fcr; > + unsigned long fesr; > + unsigned long fid; > + unsigned long reserved; > + } */ > + int i = 0; > + int fcr_regno[] = {122, 123, 121}; /* fcr, fesr, fid. */ > + > + /* Supply vr0~vr15. */ > + for (i = 0; i < 16; i ++) > + { > + if (gdbarch_register_name (gdbarch, (CSKY_VR0_REGNUM + i))) > + { > + offset = 16 * i; > + regcache ->raw_collect (CSKY_VR0_REGNUM + i, > + fregs + offset); > + } > + } > + /* Supply fr16~fr31. */ > + for (i = 0; i < 16; i ++) > + { > + if (gdbarch_register_name (gdbarch, (CSKY_FR16_REGNUM + > i))) > + { > + offset = (16 * 16) + (8 * i); > + regcache ->raw_collect (CSKY_FR16_REGNUM + i, > + fregs + offset); > + } > + } > + /* Supply fcr, fesr, fid. */ > + for (i = 0; i < 3; i ++) > + { > + if (gdbarch_register_name (gdbarch, fcr_regno[i])) > + { > + offset = (16 * 16) + (16 * 8) + (4 * i); > + regcache ->raw_collect (fcr_regno[i], > + fregs + offset); > + } > + } > + } > + else > { > - if ((regnum == csky_fregset_offset[regno] || regnum == -1) > - && csky_fregset_offset[regno] != -1) > - { > - offset += register_size (gdbarch, > csky_fregset_offset[regno]); > - regcache->raw_collect (regno, fregs + offset); > - } > + warning (_("Unknow size %ld of section .reg2, will not set > value" > + " of float registers."), len); > } > } > > @@ -166,7 +281,10 @@ static const struct regset csky_regset_float = > { > NULL, > csky_supply_fregset, > - csky_collect_fregset > + csky_collect_fregset, > + /* Allow .reg2 has different size, buf size of .reg2 should > + always is or bigger than SIZEOF_CSKY_FREGSET. */ I recommend a slightly different wording for the above comment: /* Allow .reg2 to have a different size, but the size of .reg2 should always be bigger than SIZEOF_CSKY_FREGSET. */ > + 1 > }; > > /* Iterate over core file register note sections. */ > -- > 2.25.1 >