Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jiangshuai Li via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Jiangshuai Li <jiangshuai_li@linux.alibaba.com>
Subject: [PATCH v2] gdb/csky support .reg2 for kernel 4.x and later
Date: Mon, 25 Jul 2022 10:44:59 +0800	[thread overview]
Message-ID: <20220725024459.21042-1-jiangshuai_li@linux.alibaba.com> (raw)

When kernel's version >= 4.x, the size of .reg2 section will be 400.
Contents of .reg2 are {
    unsigned long vr[96]; // vr0~vr15 & fr16~fr31
    unsigned long fcr;
    unsigned long fesr;
    unsigned long fid;
    unsigned long reserved;
};
---
 gdb/csky-linux-tdep.c | 150 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 134 insertions(+), 16 deletions(-)

diff --git a/gdb/csky-linux-tdep.c b/gdb/csky-linux-tdep.c
index 440045e7713..aa85a299922 100644
--- a/gdb/csky-linux-tdep.c
+++ b/gdb/csky-linux-tdep.c
@@ -36,6 +36,8 @@
 #define SIZEOF_CSKY_GREGSET 34*4
 /* Float regset fesr fsr fr0-fr31 for CK810.  */
 #define SIZEOF_CSKY_FREGSET 34*4
+/* Float regset vr0~vr15 fr15~fr31, reserved for CK810 when kernel 4.x.  */
+#define SIZEOF_CSKY_FREGSET_K4X  400
 
 /* Offset mapping table from core_section to regcache of general
    registers for ck810.  */
@@ -118,15 +120,76 @@ csky_supply_fregset (const struct regset *regset,
   int fregset_num = ARRAY_SIZE (csky_fregset_offset);
 
   gdb_assert (len >= SIZEOF_CSKY_FREGSET);
-  for (i = 0; i < fregset_num; i++)
+  if (len == SIZEOF_CSKY_FREGSET)
     {
-      if ((regnum == csky_fregset_offset[i] || regnum == -1)
-	  && csky_fregset_offset[i] != -1)
-	{
-	  int num = csky_fregset_offset[i];
-	  offset += register_size (gdbarch, num);
-	  regcache->raw_supply (csky_fregset_offset[i], fregs + offset);
-	}
+      for (i = 0; i < fregset_num; i++)
+        {
+          if ((regnum == csky_fregset_offset[i] || regnum == -1)
+              && csky_fregset_offset[i] != -1)
+            {
+              int num = csky_fregset_offset[i];
+              offset += register_size (gdbarch, num);
+              regcache->raw_supply (csky_fregset_offset[i], fregs + offset);
+            }
+        }
+    }
+  else if (len == SIZEOF_CSKY_FREGSET_K4X)
+    {
+      /* When kernel version >= 4.x, .reg2 size will be 400.
+         Contents is {
+           unsigned long vr[96]; // vr0~vr15 + fr16~fr31
+           unsigned long fcr;
+           unsigned long fesr;
+           unsigned long fid;
+           unsigned long reserved;
+         }  */
+      int fcr_regno[] = {122, 123, 121}; /* fcr, fesr, fid.  */
+
+      /* Supply vr0~vr15.  */
+      for (i = 0; i < 16; i ++)
+        {
+          if (gdbarch_register_name (gdbarch, (CSKY_VR0_REGNUM + i)))
+            {
+              offset = 16 * i;
+              regcache->raw_supply (CSKY_VR0_REGNUM + i,
+                                    fregs + offset);
+            }
+        }
+      /* Supply fr0~fr15.  */
+      for (i = 0; i < 16; i ++)
+        {
+          if (gdbarch_register_name (gdbarch, (CSKY_FR0_REGNUM + i)))
+            {
+              offset = 16 * i;
+              regcache->raw_supply (CSKY_FR0_REGNUM + i,
+                                    fregs + offset);
+            }
+        }
+      /* Supply fr16~fr31.  */
+      for (i = 0; i < 16; i ++)
+        {
+          if (gdbarch_register_name (gdbarch, (CSKY_FR16_REGNUM + i)))
+            {
+              offset = (16 * 16) + (8 * i);
+              regcache->raw_supply (CSKY_FR16_REGNUM + i,
+                                    fregs + offset);
+            }
+        }
+     /* Supply fcr, fesr, fid.  */
+      for (i = 0; i < 3; i ++)
+        {
+          if (gdbarch_register_name (gdbarch, fcr_regno[i]))
+            {
+              offset = (16 * 16) + (16 * 8) + (4 * i);
+              regcache->raw_supply (fcr_regno[i],
+                                    fregs + offset);
+            }
+        }
+    }
+  else
+    {
+      warning (_("Unknow size %ld of section .reg2, can not get value"
+                 " of float registers."), len);
     }
 }
 
@@ -144,14 +207,66 @@ csky_collect_fregset (const struct regset *regset,
   int offset = 0;
 
   gdb_assert (len >= SIZEOF_CSKY_FREGSET);
-  for (regno = 0; regno < fregset_num; regno++)
+  if (len == SIZEOF_CSKY_FREGSET)
+    {
+      for (regno = 0; regno < fregset_num; regno++)
+        {
+          if ((regnum == csky_fregset_offset[regno] || regnum == -1)
+               && csky_fregset_offset[regno] != -1)
+            {
+              offset += register_size (gdbarch, csky_fregset_offset[regno]);
+              regcache->raw_collect (regno, fregs + offset);
+            }
+        }
+    }
+  else if (len == SIZEOF_CSKY_FREGSET_K4X)
+    {
+      /* When kernel version >= 4.x, .reg2 size will be 400.
+         Contents is {
+           unsigned long vr[96]; // vr0~vr15 + fr16~fr31
+           unsigned long fcr;
+           unsigned long fesr;
+           unsigned long fid;
+           unsigned long reserved;
+         }  */
+      int i = 0;
+      int fcr_regno[] = {122, 123, 121}; /* fcr, fesr, fid.  */
+
+      /* Supply vr0~vr15.  */
+      for (i = 0; i < 16; i ++)
+        {
+          if (gdbarch_register_name (gdbarch, (CSKY_VR0_REGNUM + i)))
+            {
+              offset = 16 * i;
+              regcache ->raw_collect (CSKY_VR0_REGNUM + i,
+                                      fregs + offset);
+            }
+        }
+      /* Supply fr16~fr31.  */
+      for (i = 0; i < 16; i ++)
+        {
+          if (gdbarch_register_name (gdbarch, (CSKY_FR16_REGNUM + i)))
+            {
+              offset = (16 * 16) + (8 * i);
+              regcache ->raw_collect (CSKY_FR16_REGNUM + i,
+                                      fregs + offset);
+            }
+        }
+      /* Supply fcr, fesr, fid.  */
+      for (i = 0; i < 3; i ++)
+        {
+          if (gdbarch_register_name (gdbarch, fcr_regno[i]))
+            {
+              offset = (16 * 16) + (16 * 8) + (4 * i);
+              regcache ->raw_collect (fcr_regno[i],
+                                      fregs + offset);
+            }
+        }
+    }
+  else
     {
-      if ((regnum == csky_fregset_offset[regno] || regnum == -1)
-	  && csky_fregset_offset[regno] != -1)
-	{
-	  offset += register_size (gdbarch, csky_fregset_offset[regno]);
-	  regcache->raw_collect (regno, fregs + offset);
-	}
+      warning (_("Unknow size %ld of section .reg2, will not set value"
+                 " of float registers."), len);
     }
 }
 
@@ -166,7 +281,10 @@ static const struct regset csky_regset_float =
 {
   NULL,
   csky_supply_fregset,
-  csky_collect_fregset
+  csky_collect_fregset,
+  /* Allow .reg2 has different size, buf size of .reg2 should
+     always is or bigger than SIZEOF_CSKY_FREGSET.  */
+  1
 };
 
 /* Iterate over core file register note sections.  */
-- 
2.25.1


             reply	other threads:[~2022-07-25  2:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  2:44 Jiangshuai Li via Gdb-patches [this message]
2022-07-27  0:49 ` Kevin Buettner via Gdb-patches
2022-07-27  7:29 jiangshuai_li via Gdb-patches
2022-07-28 17:55 ` Kevin Buettner via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220725024459.21042-1-jiangshuai_li@linux.alibaba.com \
    --to=gdb-patches@sourceware.org \
    --cc=jiangshuai_li@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox