From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MNIgDi3P0WJtvBMAWB0awg (envelope-from ) for ; Fri, 15 Jul 2022 16:33:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 2A6541E5EA; Fri, 15 Jul 2022 16:33:49 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Uw4d2c3J; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C97E51E21F for ; Fri, 15 Jul 2022 16:33:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50F8D385703C for ; Fri, 15 Jul 2022 20:33:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50F8D385703C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1657917228; bh=Y1UvR/tSikbrt/pgAzQ7Fr3N9jykZpwPPHtXEqoc2DQ=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Uw4d2c3Jf/Bwavcs8xORWEOpGOWDETtICTi4lqryV0UF+eaBvl1qKwPRqmKm2rFxi h19udg4vnL3/dKyeL92NpBmN6RwsYe8l387lori219uJhcLGrl80SGP4ndbzwZcAwf OwuKBZU/5h+9Sd+fSW+TNcRSJ9iFtTVFs6+V/ozU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 644F43857BBD for ; Fri, 15 Jul 2022 20:33:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 644F43857BBD Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-332-DKISi1S8MTavc4xs-fiUcg-1; Fri, 15 Jul 2022 16:33:19 -0400 X-MC-Unique: DKISi1S8MTavc4xs-fiUcg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3B6C185A7BA; Fri, 15 Jul 2022 20:33:18 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.17.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B956492C3B; Fri, 15 Jul 2022 20:33:18 +0000 (UTC) Date: Fri, 15 Jul 2022 13:33:17 -0700 To: Tom Tromey via Gdb-patches Subject: Re: [PATCH] Make 'import gdb.events' work Message-ID: <20220715133317.1bd0103b@f35-zws-1> In-Reply-To: <20220607132025.2243948-1-tromey@adacore.com> References: <20220607132025.2243948-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, 7 Jun 2022 07:20:25 -0600 Tom Tromey via Gdb-patches wrote: > + /* Define all internal modules. These are all imported (and thus > + created) during initialization. */ > + struct _inittab mods[3] = > + { > + { "_gdb", init__gdb_module }, > + { "_gdbevents", gdbpy_events_mod_func }, > + { nullptr, nullptr } > + }; Something I just noticed while looking at a conflict while rebasing my Python 3.11 deprecation patch: Is there any reason not to do... struct _inittab mods[] = ... instead? Since I've had to move this hunk of code, I've made the above tweak in my (soon to come) v3 Python 3.11 deprecation patch. Kevin