From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PAhLOjvSz2J+lxIAWB0awg (envelope-from ) for ; Thu, 14 Jul 2022 04:22:19 -0400 Received: by simark.ca (Postfix, from userid 112) id E0D231E21F; Thu, 14 Jul 2022 04:22:19 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Qib11j01; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 84E361E21F for ; Thu, 14 Jul 2022 04:22:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA0A3385740C for ; Thu, 14 Jul 2022 08:22:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA0A3385740C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1657786938; bh=Msywxb7sq91GbCNrtw8frlzyFW+J/jcKKtWM2z5eUao=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Qib11j014C8vv21G+gVPnjmXNRPySybU6yFlTjZjqyTnZWCXys87xQ/s13TkIlLu1 /GB/GSU1Q8sKBYbREyjmUxagUuqPN46C1e2Lkkho8MaGCRyzTW1wotMQIzRXJ7AXQh U2BrY+yp76bSwbuNdQMmX2b/3n3OksqnAcpyU33c= Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C1D683848591 for ; Thu, 14 Jul 2022 08:20:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1D683848591 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 08638207B2 for ; Thu, 14 Jul 2022 08:20:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E8A6813748 for ; Thu, 14 Jul 2022 08:20:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PX16N+nRz2I7WQAAMHmgww (envelope-from ) for ; Thu, 14 Jul 2022 08:20:57 +0000 Date: Thu, 14 Jul 2022 10:20:56 +0200 To: gdb-patches@sourceware.org Subject: [committed][gdb/build] Fix gdb build with gcc 4.8.5 Message-ID: <20220714082054.GA21481@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, When building gdb with gcc 4.8.5, we run into: ... In file included from /usr/include/c++/4.8/future:43:0, from gdbsupport/thread-pool.h:30, from gdb/dwarf2/cooked-index.h:33, from gdb/dwarf2/read.h:26, from gdb/dwarf2/abbrev-cache.c:21: /usr/include/c++/4.8/atomic: In instantiation of \ ‘_Tp std::atomic<_Tp>::load(std::memory_order) const [with _Tp = \ packed; std::memory_order = std::memory_order]’: gdb/dwarf2/read.h:332:44: required from here /usr/include/c++/4.8/atomic:208:13: error: no matching function for call to \ ‘packed::packed()’ _Tp tmp; ^ ... Fix this by adding the default constructor for packed. Tested on x86_64-linux, with gdb build with gcc 4.8.5. Committed to trunk. Thanks, - Tom [gdb/build] Fix gdb build with gcc 4.8.5 --- gdbsupport/packed.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdbsupport/packed.h b/gdbsupport/packed.h index cd331b5477d..3468cf44207 100644 --- a/gdbsupport/packed.h +++ b/gdbsupport/packed.h @@ -31,6 +31,8 @@ template struct packed { public: + packed () noexcept = default; + packed (T val) { m_val = val;