Re: [PATCH 1/5] regcache: Add collect/supply_regset variants that accept a register base.

Simon Marchi via Gdb-patches
2022-11-22T20:18:41Z

>> diff --git a/gdb/regcache.h b/gdb/regcache.h
>> index 1dbba5ce9af..f01127b20fb 100644
>> --- a/gdb/regcache.h
>> +++ b/gdb/regcache.h
>> @@ -150,6 +150,14 @@ extern void regcache_collect_regset (const struct regset *regset,
>> int regnum, void *buf, size_t size);
>>
>>
>> +extern void regcache_supply_regset (const struct regset *regset, int regbase,
>> + struct regcache *regcache,
>> + int regnum, const void *buf,
>> + size_t size);
>> +extern void regcache_collect_regset (const struct regset *regset, int regbase,
>> + const struct regcache *regcache,
>> + int regnum, void *buf, size_t size);
>
> These don't have a definition, I guess they are not needed.
>
> (Could we make a patch that removes regcache_supply_regset and
> regcache_collect_regset, since they just forward to the regcache
> methods?)

Answering my own question, no we can't. They are used as callbacks in
regset structures.

Simon