Re: [PATCH 1/5] regcache: Add collect/supply_regset variants that accept a register base.

Simon Marchi via Gdb-patches
2022-11-22T19:58:25Z

On 7/7/22 20:58, John Baldwin wrote:
> Some register sets described by an array of regcache_map_entry
> structures do not have fixed register numbers in their associated
> architecture but do describe a block of registers whose numbers are at
> fixed offsets relative to some base register value. An example of
> this are the TLS register sets for the ARM and AArch64 architectures.
>
> Currently OS-specific architectures create register maps and register
> sets dynamically using the register base number. However, this
> requires duplicating the code to create the register map and register
> set. To reduce duplication, add variants of the collect_regset and
> supply_regset regcache methods which accept a base register number.
> For valid register map entries (i.e. not REGCACHE_MAP_SKIP), add this
> base register number to the value from the map entry to determine the
> final register number.

The patch LGTM. I have some small comments, once addressed you can put
my:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

> ---
> gdb/regcache.c | 28 +++++++++++++++++++++++++---
> gdb/regcache.h | 24 ++++++++++++++++++++++--
> 2 files changed, 47 insertions(+), 5 deletions(-)
>
> diff --git a/gdb/regcache.c b/gdb/regcache.c
> index 037659ef8fa..1db3d972ef8 100644
> --- a/gdb/regcache.c
> +++ b/gdb/regcache.c
> @@ -1180,7 +1180,7 @@ regcache::transfer_regset_register (struct regcache *out_regcache, int regnum,
> /* See regcache.h. */
>
> void
> -regcache::transfer_regset (const struct regset *regset,
> +regcache::transfer_regset (const struct regset *regset, int regbase,
> struct regcache *out_regcache,
> int regnum, const gdb_byte *in_buf,
> gdb_byte *out_buf, size_t size) const
> @@ -1195,6 +1195,9 @@ regcache::transfer_regset (const struct regset *regset,
> int regno = map->regno;
> int slot_size = map->size;
>
> + if (regno != REGCACHE_MAP_SKIP)
> + regno += regbase;
> +
> if (slot_size == 0 && regno != REGCACHE_MAP_SKIP)
> slot_size = m_descr->sizeof_register[regno];
>
> @@ -1242,7 +1245,18 @@ void
> regcache::supply_regset (const struct regset *regset,
> int regnum, const void *buf, size_t size)
> {
> - transfer_regset (regset, this, regnum, (const gdb_byte *) buf, nullptr, size);
> + transfer_regset (regset, 0, this, regnum, (const gdb_byte *) buf, nullptr,
> + size);
> +}

Can the old regcache::{supply,collect}_regset (without regbase) become
trivial wrappers around the new ones (with regbase)? I would put the
implementation directly in the .h if doing that.

> +
> +/* See regcache.h. */
> +
> +void
> +regcache::supply_regset (const struct regset *regset, int regbase,
> + int regnum, const void *buf, size_t size)
> +{
> + transfer_regset (regset, regbase, this, regnum, (const gdb_byte *) buf,
> + nullptr, size);
> }
>
> /* Collect register REGNUM from REGCACHE to BUF, using the register
> @@ -1261,11 +1275,19 @@ void
> regcache::collect_regset (const struct regset *regset,
> int regnum, void *buf, size_t size) const
> {
> - transfer_regset (regset, nullptr, regnum, nullptr, (gdb_byte *) buf, size);
> + transfer_regset (regset, 0, nullptr, regnum, nullptr, (gdb_byte *) buf, size);
> }
>
> /* See regcache.h */
>
> +void
> +regcache::collect_regset (const struct regset *regset, int regbase,
> + int regnum, void *buf, size_t size) const
> +{
> + transfer_regset (regset, regbase, nullptr, regnum, nullptr, (gdb_byte *) buf,
> + size);
> +}
> +
> bool
> regcache_map_supplies (const struct regcache_map_entry *map, int regnum,
> struct gdbarch *gdbarch, size_t size)
> diff --git a/gdb/regcache.h b/gdb/regcache.h
> index 1dbba5ce9af..f01127b20fb 100644
> --- a/gdb/regcache.h
> +++ b/gdb/regcache.h
> @@ -150,6 +150,14 @@ extern void regcache_collect_regset (const struct regset *regset,
> int regnum, void *buf, size_t size);
>
>
> +extern void regcache_supply_regset (const struct regset *regset, int regbase,
> + struct regcache *regcache,
> + int regnum, const void *buf,
> + size_t size);
> +extern void regcache_collect_regset (const struct regset *regset, int regbase,
> + const struct regcache *regcache,
> + int regnum, void *buf, size_t size);

These don't have a definition, I guess they are not needed.

(Could we make a patch that removes regcache_supply_regset and
regcache_collect_regset, since they just forward to the regcache
methods?)

> + belonging to the regset, otherwise just the register numbered
> + REGNUM. The REGSET's 'regmap' field must point to an array of
> + 'struct regcache_map_entry'. The valid register numbers in each
> + entry in 'struct regcache_map_entry' are offset by REGBASE. */
> +
> + void supply_regset (const struct regset *regset, int regbase,
> + int regnum, const void *buf, size_t size);
> +
> + void collect_regset (const struct regset *regset, int regbase, int regnum,
> + void *buf, size_t size) const;
> +
> void supply_regset (const struct regset *regset,
> int regnum, const void *buf, size_t size);
>
> -
> void collect_regset (const struct regset *regset, int regnum,
> void *buf, size_t size) const;

Can you document the last two, just by saying something like "Same as
the above, but with REGBASE == 0"?

Simon