From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9OmQGDOSxmIJrQ0AWB0awg (envelope-from ) for ; Thu, 07 Jul 2022 03:58:43 -0400 Received: by simark.ca (Postfix, from userid 112) id 511DC1E22D; Thu, 7 Jul 2022 03:58:43 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=t3Ktm05f; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B35D51E220 for ; Thu, 7 Jul 2022 03:58:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD90D3857410 for ; Thu, 7 Jul 2022 07:58:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD90D3857410 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1657180721; bh=ossqN0UgMRTS7iGZG2qrmd1F5P/QV2vQd5WwCjfnNyE=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=t3Ktm05fZ4pr3q7IbpKU45ibqUszcW52rGqPcN/KzL2uhu6iR/u6Ba7pckWn4EErn c3VmcObm+OZPo1N5sBppTlazQnNB2s5f+ErdZeevTADpJY5PbM6sxEzJp9DnXWOBoI y/sQ+FxL/Ni/QREAyJBlj6FLfz3lQSGx9M5q+3Ck= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 7B0C53858D32 for ; Thu, 7 Jul 2022 07:58:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B0C53858D32 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A7E9D21FDE; Thu, 7 Jul 2022 07:58:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8D1C113461; Thu, 7 Jul 2022 07:58:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MfBhIR2SxmI7ZwAAMHmgww (envelope-from ); Thu, 07 Jul 2022 07:58:21 +0000 Date: Thu, 7 Jul 2022 09:58:20 +0200 To: gdb-patches@sourceware.org Subject: [PATCH][gdb/build] Handle deprecation of scm_install_gmp_memory_functions Message-ID: <20220707075809.GA16313@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Cc: Ludovic =?iso-8859-1?Q?Court=E8s?= Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, When building gdb with guile 3.0.8, we run into: ... gdb/guile/guile.c: In function \ 'void gdbscm_initialize(const extension_language_defn*)': gdb/guile/guile.c:680:5: error: 'scm_install_gmp_memory_functions' is \ deprecated [-Werror=deprecated-declarations] 680 | scm_install_gmp_memory_functions = 0; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/guile/3.0/libguile.h:128, from gdb/guile/guile-internal.h:30, from gdb/guile/guile.c:36: /usr/include/guile/3.0/libguile/deprecated.h:164:20: note: declared here 164 | SCM_DEPRECATED int scm_install_gmp_memory_functions; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors make[1]: *** [Makefile:1896: guile/guile.o] Error 1 ... The variable has been deprecated because it no longer has any effect. Fix this by disabling the specific deprecation warning. Also handle upcoming guile versions > 3.0, in which the variable will be removed, by limiting the usage of the variable to guile versions <= 3.0. This does not break anything. The variable was merely used to address a problem present in guile versions <= v3.0.5. Note that we don't limit the usage of the variable to guile versions <= 3.0.5, because we want to support f.i. building against 3.0.6 and then using a shared lib with 3.0.5. Tested on x86_64-linux. Co-Authored-By: Tom de Vries Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28994 Any comments? Thanks, - Tom [gdb/build] Handle deprecation of scm_install_gmp_memory_functions --- gdb/guile/guile.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gdb/guile/guile.c b/gdb/guile/guile.c index 14b191ded62..e5565b627d9 100644 --- a/gdb/guile/guile.c +++ b/gdb/guile/guile.c @@ -677,7 +677,17 @@ gdbscm_initialize (const struct extension_language_defn *extlang) "double free or corruption (out)" error. Work around the libguile bug by disabling the installation of the libgmp memory functions by guile initialization. */ + + /* The scm_install_gmp_memory_functions variable should be removed after + version 3.0, so limit usage to 3.0 and before. */ +#if SCM_MAJOR_VERSION < 3 || (SCM_MAJOR_VERSION == 3 && SCM_MINOR_VERSION == 0) + /* This variable is deprecated in Guile 3.0.8 and later but remains + available in the whole 3.0 series. */ +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wdeprecated-declarations" scm_install_gmp_memory_functions = 0; +#pragma GCC diagnostic pop +#endif /* scm_with_guile is the most portable way to initialize Guile. Plus we need to initialize the Guile support while in Guile mode (e.g.,