From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id E/xLO51OtmK7uwUAWB0awg (envelope-from ) for ; Fri, 24 Jun 2022 19:54:05 -0400 Received: by simark.ca (Postfix, from userid 112) id E029A1E22C; Fri, 24 Jun 2022 19:54:05 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=TRxnpZAj; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8AC301E22A for ; Fri, 24 Jun 2022 19:54:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 272AE383D82C for ; Fri, 24 Jun 2022 23:54:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 272AE383D82C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1656114844; bh=F+pIhcYnOUaSn855GSdfnd07Eo3cegvofBnktri+9ls=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=TRxnpZAjcJuXSZ7/LPULB+OsQzQ7b27RIuF5yUypHeYdblMuPerbxHrKp03gVQEhE +/s5eArT2+gl5C1ggmI5MsHSKZ0rbHxDITb2sXu9Kxkz0vJ2w4LHrc3i3lu8fdLn6f On5xab0I9vzA3tWBY9bXKsTi7pLb2bBCOARAwoG8= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A764B383DBBF for ; Fri, 24 Jun 2022 23:53:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A764B383DBBF Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-256-0Qj5GCaFNCOjof0NV_SLTQ-1; Fri, 24 Jun 2022 19:53:41 -0400 X-MC-Unique: 0Qj5GCaFNCOjof0NV_SLTQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED1AF85A589; Fri, 24 Jun 2022 23:53:40 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 94A702166B29; Fri, 24 Jun 2022 23:53:40 +0000 (UTC) Date: Fri, 24 Jun 2022 16:53:39 -0700 To: Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 10/15] gdb, ada: update ada_add_all_symbols Message-ID: <20220624165339.3bc15341@f35-zws-1> In-Reply-To: <20220602132514.957983-11-markus.t.metzger@intel.com> References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-11-markus.t.metzger@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 2 Jun 2022 15:25:09 +0200 Markus Metzger via Gdb-patches wrote: > Iterate over objfile in search order using the objfile of the context > block as current_objfile so the iteration can stay inside the block's > linker namespace. > --- > gdb/ada-lang.c | 66 +++++++++++++++++++++++++++++++++----------------- > 1 file changed, 44 insertions(+), 22 deletions(-) This (also) looks reasonable to me. However, as stated in another review, I'm not an expert in this area; someone who is might want to give it a look... Kevin