From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4PJUMhehtGLWpgQAWB0awg (envelope-from ) for ; Thu, 23 Jun 2022 13:21:27 -0400 Received: by simark.ca (Postfix, from userid 112) id CB4101E225; Thu, 23 Jun 2022 13:21:27 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=p93kXq4W; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 781AE1E15D for ; Thu, 23 Jun 2022 13:21:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D4833857356 for ; Thu, 23 Jun 2022 17:21:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D4833857356 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1656004884; bh=LG9FFxOuF/Yy1gxFSCm0qH5j+ati/0dSwQYWoh0+kIg=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=p93kXq4WaaoDAHWa25AZNEar+nYHXB/9raxcW+nHsOou7L70qwWSkHVryhITWJyrh /w12fY5HIY3R/IPof5H11pN+1CC20huC990fVTlnQo59jS/XlPahDzJguEzf78KqyQ ZuURbe/QMlrEF+8gYVCGGXQ+SxbOsCBBLJPpQcD8= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 576EC3858C55 for ; Thu, 23 Jun 2022 17:21:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 576EC3858C55 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-549-_gR4pY-BO9qGzndh-unNcw-1; Thu, 23 Jun 2022 13:21:00 -0400 X-MC-Unique: _gR4pY-BO9qGzndh-unNcw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8867D1C16B44; Thu, 23 Jun 2022 17:21:00 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 444BB40CF8EE; Thu, 23 Jun 2022 17:21:00 +0000 (UTC) Date: Thu, 23 Jun 2022 10:20:58 -0700 To: Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 06/15] gdb, compile: unlink objfile stored in module Message-ID: <20220623102058.45d572ef@f35-zws-1> In-Reply-To: <20220602132514.957983-7-markus.t.metzger@intel.com> References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-7-markus.t.metzger@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 2 Jun 2022 15:25:05 +0200 Markus Metzger via Gdb-patches wrote: > When cleaning up after a compile command, we iterate over all objfiles and > unlink the first objfile with the same name as the one we compiled. > > Since we already store a pointer to that objfile in the module and use it > to get the name we're comparing against, there's no reason to iterate, at > all. We can simply use that objfile. > > This further avoids potential issues when an objfile with the same name is > loaded into a different linker namespace. > --- > gdb/compile/compile-object-run.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) LGTM. Kevin