Re: [PATCH] gdb: reject inserting breakpoints between functions

Simon Marchi
2024-05-01T18:12:18Z

On 2024-05-01 05:47, Andrew Burgess wrote:
> Klaus Gerlicher <klaus.gerlicher@intel.com> writes:
>
>> Hi Simon,
>>
>> I verified that your patch addresses many of the issues we would also
>> like to solve in this area.
>>
>> It appears this has not published yet and it seems to be more than 2
>> years old.
>>
>> Could you please tell me if there are any plans to commit this?
>
> Given I reviewed this once upon a time, I still had my review branch
> kicking around.
>
> I rebased onto something close to HEAD of master. I addressed the minor
> nits I pointed out in my review. I'd be happy to see this merged once
> my full regression run (still on going) has completed.
>
> I think I'd like Simon to give a +1 before I pushed this though.
>
> Thanks,
> Andrew

Thanks for reminding me about this, it clearly fell through the cracks.
And thanks Andrew for following up on it. What you posted looks good to
me. We discussed it internally, Pedro suggested to maybe wait after the
GDB 15 branch is created before pushing this one, to give it more
testing time in master before it reaches a release.

Simon