RE: [PATCH] gdb: reject inserting breakpoints between functions

Gerlicher, Klaus
2024-08-30T05:38:43Z

Hi Simon,

Thanks, I will look at rebasing my patch.

Klaus

> -----Original Message-----
> From: Simon Marchi <simark@simark.ca>
> Sent: Thursday, August 29, 2024 9:02 PM
> To: Simon Marchi <simon.marchi@efficios.com>; Gerlicher, Klaus
> <klaus.gerlicher@intel.com>; Andrew Burgess <aburgess@redhat.com>
> Cc: Simon.Marchi@amd.com; gdb-patches@sourceware.org
> Subject: Re: [PATCH] gdb: reject inserting breakpoints between functions
>
>
>
> On 2024-08-12 10:54, Simon Marchi wrote:
> > On 8/7/24 4:27 AM, Gerlicher, Klaus wrote:
> >> Hi Simon,
> >>
> >> Kindly reminding again about your breakpoint sliding patch.
> >>
> >> I worked a bit with it, I have had one additional issue that would be fixed
> with below patch but of course since your original patch hasn't landed yet I
> can't post this as a real patch.
> >>
> >> So if you want to integrate this to your patch or treat this in another way,
> please let me know.
> >>
> >> Thanks
> >> Klaus
> >
> > Thanks for reminding me... I'll try to come back to this this week.
> >
> > Simon
>
> I went ahead and pushed Andrew's version of my patch, with one
> small change, to use a reference instead of a pointer.
>
> Klaus, can you rebase and re-post your patch?
>
> Simon
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928