From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lDZqBM9Bn2IYNAsAWB0awg (envelope-from ) for ; Tue, 07 Jun 2022 08:17:19 -0400 Received: by simark.ca (Postfix, from userid 112) id F27401E222; Tue, 7 Jun 2022 08:17:18 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=OqfOv1ix; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4571C1E143 for ; Tue, 7 Jun 2022 08:17:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 551E4381DC78 for ; Tue, 7 Jun 2022 12:17:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 551E4381DC78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1654604237; bh=10Yfof0BPkNzbMiWy+UUxFx8nbGArmAn6GqnFiSKXx4=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=OqfOv1ixokWjDv1BhXGQosvRPM+0vB82I5XY5Dmfbt0Zcg26vs2XH4hhK7sPoseDd JK51n53JyKZPkJzHv+Kx7VQ0i1DvtRnRxl7CzKZqRt54LKlrfG1JHbaUeLgEx7A0X6 ijCSqbNiJXN3C9Zfk6zGfKr3XEGOPKDAzhVZhTvQ= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 7E46A381FD2D for ; Tue, 7 Jun 2022 12:16:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E46A381FD2D Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3E52721B1A; Tue, 7 Jun 2022 12:16:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1284C13638; Tue, 7 Jun 2022 12:16:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NozTArlBn2K2BAAAMHmgww (envelope-from ); Tue, 07 Jun 2022 12:16:57 +0000 Date: Tue, 7 Jun 2022 14:16:55 +0200 To: gdb-patches@sourceware.org Subject: [PATCH][gdb] Improve "Converting character sets: Invalid argument" Message-ID: <20220607121653.GA22267@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, When running selftest rust-lex on an openSUSE Leap 15.3 system with glibc-locale-base and glibc-locale packages deinstalled, we run into: ... $ gdb -q -batch -ex "maint selftest rust-lex" Running selftest rust-lex. Self test failed: Converting character sets: Invalid argument. Ran 1 unit tests, 1 failed ... The "invalid argument" is due to iconv_open returning EINVALID, meaning the conversion is not supported by the implementation. Make the error more informative, such that we have: ... Self test failed: Cannot convert between character sets `ANSI_X3.4-1968' and \ `UTF-32LE' ... Tested on x86_64-linux. https://sourceware.org/bugzilla/show_bug.cgi?id=29202 Any comments? Thanks, - Tom [gdb] Improve "Converting character sets: Invalid argument" --- gdb/charset.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gdb/charset.c b/gdb/charset.c index 74f742e0aa7..e182a67d683 100644 --- a/gdb/charset.c +++ b/gdb/charset.c @@ -474,7 +474,14 @@ class iconv_wrapper { m_desc = iconv_open (to, from); if (m_desc == (iconv_t) -1) - perror_with_name (_("Converting character sets")); + { + if (errno == EINVAL) + throw_error (NOT_SUPPORTED_ERROR, + _("Cannot convert between character sets `%s' and `%s'"), + from, to); + else + perror_with_name (_("Converting character sets")); + } } ~iconv_wrapper ()