From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fAN/HGt9l2JKtAkAWB0awg (envelope-from ) for ; Wed, 01 Jun 2022 10:53:31 -0400 Received: by simark.ca (Postfix, from userid 112) id 65DFF1E221; Wed, 1 Jun 2022 10:53:31 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=sdhBGosy; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CC4411E01D for ; Wed, 1 Jun 2022 10:53:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1B2FD38303D9 for ; Wed, 1 Jun 2022 14:53:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B2FD38303D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1654095210; bh=mZGNdKkql+i2KUsIFF9ytT7COnV2JattsXsS3IdikQc=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sdhBGosydxwLt1yhYwLDU4n0uV8ms+r96QrlCHM6Mh9D57eCRdFje4jFWdxxOuqU8 yTG9qNevrioIQbL5A7IFO0wYS1IKRx18OI5kjLm6VQ1N5st5UVkQmQhlue2uwCcxak 3I0jH7br+v8z8fgWZWC85Ah9LZEAxIYh3PDdcZWU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9C5D03857BA4 for ; Wed, 1 Jun 2022 14:53:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C5D03857BA4 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-473-yuOO34tGNrKPYfZo58EMtQ-1; Wed, 01 Jun 2022 10:53:09 -0400 X-MC-Unique: yuOO34tGNrKPYfZo58EMtQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 385C81C00ACE for ; Wed, 1 Jun 2022 14:53:09 +0000 (UTC) Received: from blarsen.com (ovpn-116-184.gru2.redhat.com [10.97.116.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8583540CFD0A; Wed, 1 Jun 2022 14:53:08 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH] gdb/testsuite: Add test to step through function epilogue Date: Wed, 1 Jun 2022 11:52:10 -0300 Message-Id: <20220601145209.16632-1-blarsen@redhat.com> In-Reply-To: <87h757dslm.fsf@redhat.com> References: <87h757dslm.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Bruno Larsen via Gdb-patches Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" The testsuite implicitly tests GDB's ability to step through epilogues in multiple tests, without doing it explicitly anywhere. This is unfortunate, as clang does not emit epilogue information, so using clang on our testsuite makes many tests fail. This patch adds a central, explicit test for walking through the epilogue so we can safely remove this from other tests and have them working with clang. The test created attempts to step through a simple empilogue, an epilogue that ends on another epilogue, and epilogues leading to other function calls. --- .../gdb.base/step-through-epilogue.c | 15 ++++ .../gdb.base/step-through-epilogue.exp | 86 +++++++++++++++++++ 2 files changed, 101 insertions(+) create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.c create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.exp diff --git a/gdb/testsuite/gdb.base/step-through-epilogue.c b/gdb/testsuite/gdb.base/step-through-epilogue.c new file mode 100644 index 00000000000..3e0ea5a2522 --- /dev/null +++ b/gdb/testsuite/gdb.base/step-through-epilogue.c @@ -0,0 +1,15 @@ +int multiply (int a, int b){ + return a*b; +} + +int square (int x){ + return multiply (x, x); +} + +int main(){ + int x; + x = multiply (1,2); + x = square(2); + x = multiply (square (1), square (2)); + return 0; +} diff --git a/gdb/testsuite/gdb.base/step-through-epilogue.exp b/gdb/testsuite/gdb.base/step-through-epilogue.exp new file mode 100644 index 00000000000..762623cf72c --- /dev/null +++ b/gdb/testsuite/gdb.base/step-through-epilogue.exp @@ -0,0 +1,86 @@ +# Copyright 2022 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# This test is used to confirm that GDB is able to step, stopping at an +# epilogue line, then step out of the function. + +standard_testfile + +if { [get_compiler_info "clang-*"] } { + untested "This test can't be used with clang" + return +} + +if { [prepare_for_testing "failed to prepare" "skip" \ + {step-through-epilogue.c}] } { + untested "failed to prepare" + return +} + +if { ![runto_main] } { + untested "couldn't run to main" + return +} + +# Some gcc versions, at least 6.5.0 and 9.2.0, can mess this test by +# requiring extra steps in a few locations. We test here and use +# this knowledge later to decide if the extra steps need to be taken. +set slow_gcc 0 +if { [test_compiler_info "gcc-6-5-0"] || [test_compiler_info "gcc-9-2-0"]} { + set slow_gcc 1 +} + +proc step_till_epilogue_multiply {} { + gdb_test "step" ".*return a.b;.*" "step into multiply" + gdb_test "step" ".*3\\s+\\\}.*" "stop at the epilogue of multiply" +} + +proc step_till_epilogue_square {} { + gdb_test "step" ".*return multiply.*" "step into square" + step_till_epilogue_multiply + gdb_test "step" ".*7\\s+\\\}.*" "stop at epilogue of square" +} + +with_test_prefix "multiply" { + step_till_epilogue_multiply + gdb_test "step" ".*x = square\\(2\\);" "leave function" +} + +with_test_prefix "square" { + step_till_epilogue_square + gdb_test "step" ".*x = multiply \\(square \\(1\\), square \\(2\\)\\);.*"\ + "leave function" +} + +with_test_prefix "square, first argument" { + step_till_epilogue_square + if {$slow_gcc} { + gdb_test "step"\ + ".*x = multiply \\(square \\(1\\), square \\(2\\)\\);.*"\ + "step back to main" + } +} +with_test_prefix "square, second argument" { + step_till_epilogue_square + if {$slow_gcc} { + gdb_test "step"\ + ".*x = multiply \\(square \\(1\\), square \\(2\\)\\);.*"\ + "step back to main" + } +} +with_test_prefix "multiply with function args" { + step_till_epilogue_multiply + gdb_test "step" ".*return 0;.*" "leave last function" +} -- 2.31.1