From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AEU+E+OYj2KMhQgAWB0awg (envelope-from ) for ; Thu, 26 May 2022 11:12:35 -0400 Received: by simark.ca (Postfix, from userid 112) id 4B6291E220; Thu, 26 May 2022 11:12:35 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=jnQYw4ff; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BCFD61E01D for ; Thu, 26 May 2022 11:12:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6C3CD3857350 for ; Thu, 26 May 2022 15:12:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C3CD3857350 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1653577954; bh=drK98RgAYos/E71nZSOJZ3EQQqBXpx3ue/wQnsFTuwo=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=jnQYw4ffojzqmUET79KEk01OkuYM7qEekKJoQGWqcdfbFEt+dosDCS1iJwDhdf8Q9 aPZ7jZXgqxtvXcyOWa74xwX5/a3Ux8VQBqGbxNx0GmIeNizDYA/WaKb/RfE8YAp6q1 FWFZ061fQjWOc7YXt8bOHnTtzJPHgvEB3ahDqZGk= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EA33B3857367 for ; Thu, 26 May 2022 15:11:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA33B3857367 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-19-OptKgz8sOpynOLGAhjzz6Q-1; Thu, 26 May 2022 11:11:11 -0400 X-MC-Unique: OptKgz8sOpynOLGAhjzz6Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D91B3C1014A for ; Thu, 26 May 2022 15:11:11 +0000 (UTC) Received: from blarsen.com (ovpn-116-42.gru2.redhat.com [10.97.116.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC11A2026D07; Thu, 26 May 2022 15:11:10 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH v3 02/14] Change gdb.base/skip-solib.exp deal with lack of epilogue information Date: Thu, 26 May 2022 12:10:29 -0300 Message-Id: <20220526151041.23223-3-blarsen@redhat.com> In-Reply-To: <20220526151041.23223-1-blarsen@redhat.com> References: <20220526151041.23223-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Bruno Larsen via Gdb-patches Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When running gdb.base/skip-solib.exp, the backtrace tests could fail if the compiler did not emit epilogue information for trivial epilogues, despite the feature being fully functional. As an example, when testing skipping the function square, the testsuite would show Breakpoint 1, main () at (...)/binutils-gdb/gdb/testsuite/gdb.base/skip-solib-main.c:5 5 return square(0); (gdb) step 0x00007ffff7cef560 in __libc_start_call_main () from /lib64/libc.so.6 (gdb) PASS: gdb.base/skip-solib.exp: ignoring solib file: step bt #0 0x00007ffff7cef560 in __libc_start_call_main () from /lib64/libc.so.6 #1 0x00007ffff7cef60c in __libc_start_main_impl () from /lib64/libc.so.6 #2 0x0000000000401065 in _start () (gdb) FAIL: gdb.base/skip-solib.exp: ignoring solib file: bt Which means that the feature is working, the testsuite is just mis-identifying it. To avoid this problem, the skipped function calls have been sent to a line before `return`, so epilogues won't factor in. This commit has also changed a few hardcoded steps to leave functions to the newly introduced gdb_step_until_regexp to leave those functions. --- No change in v3 v2: chagned to use step_until_regexp instead of finish --- gdb/testsuite/gdb.base/skip-inline.exp | 18 +++++++++++------- gdb/testsuite/gdb.base/skip-solib-lib.c | 3 ++- gdb/testsuite/gdb.base/skip-solib-main.c | 3 ++- gdb/testsuite/gdb.base/skip-solib.exp | 12 ++++++++++-- 4 files changed, 25 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.base/skip-inline.exp b/gdb/testsuite/gdb.base/skip-inline.exp index f6e9926b66c..327ea676140 100644 --- a/gdb/testsuite/gdb.base/skip-inline.exp +++ b/gdb/testsuite/gdb.base/skip-inline.exp @@ -35,16 +35,20 @@ gdb_test "skip function foo" "Function foo will be skipped when stepping\." gdb_test "bt" "\\s*\\#0\\s+main.*" "in the main" gdb_test "step" ".*" "step into baz, since foo will be skipped" gdb_test "bt" "\\s*\\#0\\s+baz.*" "in the baz, since foo was skipped" -gdb_test "step" ".*" "step in the baz" -gdb_test "bt" "\\s*\\#0\\s+baz.*" "still in the baz" -gdb_test "step" ".*" "step back to main" +gdb_step_until_regexp ".*x = 0; x = baz \\(foo \\(\\)\\).*" gdb_test "bt" "\\s*\\#0\\s+main.*" "again in the main" gdb_test "step" ".*" "step again into baz, since foo will be skipped" gdb_test "bt" "\\s*\\#0\\s+baz.*" "again in the baz" -gdb_test "step" ".*" "step in the baz, again" -gdb_test "bt" "\\s*\\#0\\s+baz.*" "still in the baz, again" -gdb_test "step" ".*" "step back to main, again" -gdb_test "bt" "\\s*\\#0\\s+main.*" "again back to main" +gdb_step_until_regexp "main \\(\\) at .*" "step back to main, again" +gdb_test "bt" "\\s*\\#0.*main.*" "again back to main" + +# because clang doesn't add epilogue information, having a set number of +# steps puts clang more and more out of sync with gcc. It is unlikely that +# the effort of keeping both outputs will be useful. +if {[test_compiler_info "clang-*"]} { + untested "Multiple steps are not supported with clang" + return +} if ![runto_main] { return diff --git a/gdb/testsuite/gdb.base/skip-solib-lib.c b/gdb/testsuite/gdb.base/skip-solib-lib.c index b2c4d86d703..341f1440a3b 100644 --- a/gdb/testsuite/gdb.base/skip-solib-lib.c +++ b/gdb/testsuite/gdb.base/skip-solib-lib.c @@ -7,5 +7,6 @@ int multiply(int a, int b) int square(int num) { - return multiply(num, num); + int res = multiply(num, num); + return res; } diff --git a/gdb/testsuite/gdb.base/skip-solib-main.c b/gdb/testsuite/gdb.base/skip-solib-main.c index 746bb5f36bb..a3b6d417935 100644 --- a/gdb/testsuite/gdb.base/skip-solib-main.c +++ b/gdb/testsuite/gdb.base/skip-solib-main.c @@ -2,5 +2,6 @@ int square(int num); int main() { - return square(0); + int s = square(0); + return s; } diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base/skip-solib.exp index 0f2ce7e1ad8..8e61725ad1b 100644 --- a/gdb/testsuite/gdb.base/skip-solib.exp +++ b/gdb/testsuite/gdb.base/skip-solib.exp @@ -82,7 +82,7 @@ with_test_prefix "ignoring solib file" { # We shouldn't step into square(), since we skipped skip-solib-lib.c. # gdb_test "step" "" - gdb_test "bt" "#0\\s+main.*" + gdb_test "bt 1" "#0\\s+main.*" } # @@ -114,5 +114,13 @@ with_test_prefix "ignoring solib function" { # the last line of square. # gdb_test "step" "" - gdb_test "bt" "#0\\s+square.*" + gdb_test "bt 1" "#0\\s+square.*" "skipped multiply" +# gdb_test_multiple "bt 1" "skipped multiply" { +# -re "#0\\s+square.*" { +# pass "skipped multiply" +# } +# -re "#0.*main.*" { +# pass "skipped multiply" +# } +# } } -- 2.31.1