From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SKN+No2Zj2KMhQgAWB0awg (envelope-from ) for ; Thu, 26 May 2022 11:15:25 -0400 Received: by simark.ca (Postfix, from userid 112) id DB5B91E220; Thu, 26 May 2022 11:15:25 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=BXO3nKr3; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 78EF21E01D for ; Thu, 26 May 2022 11:15:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2906B3857369 for ; Thu, 26 May 2022 15:15:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2906B3857369 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1653578125; bh=YZHsYHHJ3HiRjhGeZLoeftftmZjo8jljvKQdr4IrxeQ=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BXO3nKr3m1fO3cbA8VEeFGmx0HRSoThL/5Er2ENUseb4QUPIK9RG93jLl+Nz0wtHb mTnwHFUl30l37k4u9Dv6ACiKHlIe8hmz1r1Fd7LEwztu/C0MD3PZo1HBc5hy9ezRre AiTThFGy+gLlfJQT4Bl8/oM0cK4QZ31kvw19+qOs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 73A8D385734C for ; Thu, 26 May 2022 15:11:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73A8D385734C Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-RH5-IEC0NW2HIDFk-_DoZw-1; Thu, 26 May 2022 11:11:20 -0400 X-MC-Unique: RH5-IEC0NW2HIDFk-_DoZw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 88B2C1D32367 for ; Thu, 26 May 2022 15:11:20 +0000 (UTC) Received: from blarsen.com (ovpn-116-42.gru2.redhat.com [10.97.116.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C94372026D64; Thu, 26 May 2022 15:11:19 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH v3 09/14] gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang Date: Thu, 26 May 2022 12:10:36 -0300 Message-Id: <20220526151041.23223-10-blarsen@redhat.com> In-Reply-To: <20220526151041.23223-1-blarsen@redhat.com> References: <20220526151041.23223-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Bruno Larsen via Gdb-patches Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Because Clang's -O0 is not as unoptimized as gcc's, one of the functions of gdb.base/msym-bp-shl was being optimized away, making the entire test fail. A lot of the test fail like so: (gdb) break foo Breakpoint 1 at 0x401030 (gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: break foo info breakpoint Num Type Disp Enb Address What 1 breakpoint keep y 0x0000000000401030 (gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: info breakpoint As the test expects 2 breakpoints to be placed. This can't be easily fixed by adding __attribute__ ((used)) to the function, since Clang will still optimize away the function. Because of this, the test is skipped when the it detects that Clang is being used --- No change in v3. v2: Reworded commit message --- gdb/testsuite/gdb.base/msym-bp-shl.exp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gdb/testsuite/gdb.base/msym-bp-shl.exp b/gdb/testsuite/gdb.base/msym-bp-shl.exp index 42adcb191dd..dd7d05bab52 100644 --- a/gdb/testsuite/gdb.base/msym-bp-shl.exp +++ b/gdb/testsuite/gdb.base/msym-bp-shl.exp @@ -22,6 +22,14 @@ if {[skip_shlib_tests]} { return 0 } +# Clang will optimize away the static foo, regardless of using +# __attribute__((used)), so we'll always get a single breakpoint +# making this test useless +if {[test_compiler_info {clang-*-*}]} { + untested "Clang optimizes away one of the functions" + return +} + standard_testfile msym-bp-shl-main.c msym-bp-shl-main-2.c msym-bp-shl-lib.c set srcfile ${srcdir}/${subdir}/${srcfile} set srcfile2 ${srcdir}/${subdir}/${srcfile2} -- 2.31.1