From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kDMrFszmjGJqEwgAWB0awg (envelope-from ) for ; Tue, 24 May 2022 10:08:12 -0400 Received: by simark.ca (Postfix, from userid 112) id 577371E220; Tue, 24 May 2022 10:08:12 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=FK7LeW1w; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A66AE1E00D for ; Tue, 24 May 2022 10:08:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 55A2E382DB10 for ; Tue, 24 May 2022 14:08:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55A2E382DB10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1653401291; bh=44FHNSyQZOfnwowZPQg/fGCmeu3D42cfGjXsCnnaD6A=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=FK7LeW1wrNpwoBIDlQiD3CqtDsW/oP2+gmgRrr4hW5Hx222Q1Fq4+dqC2rUQFzFC4 0ZeL70wKNC/g1qvvhr7pYgiggoX1LM6jHzez+5WouviqP46aRKPdgx48uPs7ZzPdtP /SOrSJ24PExzXAsCoI0cScH/ANK3aLKzu6Yi4otw= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 997AF38293DE for ; Tue, 24 May 2022 14:07:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 997AF38293DE Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D4FD2219BC for ; Tue, 24 May 2022 14:07:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C1A7A13ADF for ; Tue, 24 May 2022 14:07:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nSgwLpvmjGIJEgAAMHmgww (envelope-from ) for ; Tue, 24 May 2022 14:07:23 +0000 Date: Tue, 24 May 2022 16:07:22 +0200 To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Fix gdb.opt/clobbered-registers-O2.exp with clang Message-ID: <20220524140720.GA23626@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, When running test-case gdb.opt/clobbered-registers-O2.exp with clang 12.0.1, I get: ... (gdb) run ^M Starting program: clobbered-registers-O2 ^M ^M Program received signal SIGSEGV, Segmentation fault.^M gen_movsd (operand0=, operand1=) at \ clobbered-registers-O2.c:31^M 31 return *start_sequence(operand0, operand1);^M (gdb) FAIL: gdb.opt/clobbered-registers-O2.exp: runto: run to start_sequence ... The problem is that the breakpoint in start_sequence doesn't trigger, because: - the call to start_sequence in gen_movsd is optimized away, despite the __attribute__((noinline)), so the actual function start_sequence doesn't get called, and - the debug info doesn't contain inlined function info, so there's only one breakpoint location. Adding noclone and noipa alongside the noinline attribute doesn't fix this. Adding the clang-specific attribute optnone in start_sequence does, but since it inhibits all optimization, that's not a preferred solution in a gdb.opt test-case, and it would work only for clang and not other compilers that possibly have the same issue. Fix this by moving functions start_sequence and gen_movsd into their own files, as a way of trying harder to enforce noinline/noipa/noclone. Tested on x86_64-linux. Any comments? Thanks, - Tom [gdb/testsuite] Fix gdb.opt/clobbered-registers-O2.exp with clang --- gdb/testsuite/gdb.opt/clobbered-registers-O2-2.c | 24 ++++++++++++++++++++++++ gdb/testsuite/gdb.opt/clobbered-registers-O2-3.c | 22 ++++++++++++++++++++++ gdb/testsuite/gdb.opt/clobbered-registers-O2.c | 16 +--------------- gdb/testsuite/gdb.opt/clobbered-registers-O2.exp | 5 +++-- 4 files changed, 50 insertions(+), 17 deletions(-) diff --git a/gdb/testsuite/gdb.opt/clobbered-registers-O2-2.c b/gdb/testsuite/gdb.opt/clobbered-registers-O2-2.c new file mode 100644 index 00000000000..c709c043677 --- /dev/null +++ b/gdb/testsuite/gdb.opt/clobbered-registers-O2-2.c @@ -0,0 +1,24 @@ +/* This file is part of GDB, the GNU debugger. + + Copyright 2007-2022 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +extern unsigned *start_sequence (unsigned *x, unsigned *y); + +unsigned +gen_movsd (unsigned *operand0, unsigned *operand1) +{ + return *start_sequence (operand0, operand1); +} diff --git a/gdb/testsuite/gdb.opt/clobbered-registers-O2-3.c b/gdb/testsuite/gdb.opt/clobbered-registers-O2-3.c new file mode 100644 index 00000000000..664d5f20d24 --- /dev/null +++ b/gdb/testsuite/gdb.opt/clobbered-registers-O2-3.c @@ -0,0 +1,22 @@ +/* This file is part of GDB, the GNU debugger. + + Copyright 2007-2022 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +unsigned * +start_sequence (unsigned *x, unsigned *y) +{ + return (unsigned *)0xdeadbeef; +} diff --git a/gdb/testsuite/gdb.opt/clobbered-registers-O2.c b/gdb/testsuite/gdb.opt/clobbered-registers-O2.c index 83cf2267d1e..8201d99763f 100644 --- a/gdb/testsuite/gdb.opt/clobbered-registers-O2.c +++ b/gdb/testsuite/gdb.opt/clobbered-registers-O2.c @@ -15,21 +15,7 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ -#ifndef __GNUC__ -#define __attribute__(x) -#endif - -unsigned * __attribute__((noinline)) -start_sequence (unsigned * x, unsigned * y) -{ - return (unsigned *)0xdeadbeef; -}; - -unsigned __attribute__((noinline)) -gen_movsd (unsigned * operand0, unsigned * operand1) -{ - return *start_sequence(operand0, operand1); -} +extern unsigned gen_movsd (unsigned *operand0, unsigned *operand1); int main(void) { diff --git a/gdb/testsuite/gdb.opt/clobbered-registers-O2.exp b/gdb/testsuite/gdb.opt/clobbered-registers-O2.exp index e01f445688d..b38f3642840 100644 --- a/gdb/testsuite/gdb.opt/clobbered-registers-O2.exp +++ b/gdb/testsuite/gdb.opt/clobbered-registers-O2.exp @@ -18,7 +18,7 @@ # Test displaying call clobbered registers in optimized binaries. # GDB should not show incorrect values. -standard_testfile +standard_testfile .c -2.c -3.c # What compiler are we using? # @@ -26,7 +26,8 @@ if [get_compiler_info] { return -1 } -if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ +if {[prepare_for_testing "failed to prepare" $testfile \ + [list $srcfile $srcfile2 $srcfile3] \ {debug optimize=-O2 nowarnings}]} { return -1 }