From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +DaGExbMi2KG5wcAWB0awg (envelope-from ) for ; Mon, 23 May 2022 14:01:58 -0400 Received: by simark.ca (Postfix, from userid 112) id 4C1D21E220; Mon, 23 May 2022 14:01:58 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=l5QciLOt; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8613E1E143 for ; Mon, 23 May 2022 14:01:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 36553383F96E for ; Mon, 23 May 2022 18:01:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36553383F96E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1653328917; bh=jg69PTOEKphQK1C4jL+8aaXrwiZpi9u4++gihxSUdnI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=l5QciLOteh2XBf2733KXhaCx9d19+DBrMHm6k3S0mWcUXZrZbMSvfTqw5zVLTkk0j EANIdgmxT50dLqhVrgWZBxU2OhsPzyOa3F/zJnvmACCIiIhdv4UK+YMa5Ac88OC2Ww nlvFag5pN/QE7mJwmI2dljfWlvr9jmBLANdRQBOs= Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by sourceware.org (Postfix) with ESMTPS id 815D9385801E for ; Mon, 23 May 2022 18:01:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 815D9385801E X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="253183622" X-IronPort-AV: E=Sophos;i="5.91,246,1647327600"; d="scan'208";a="253183622" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 11:01:16 -0700 X-IronPort-AV: E=Sophos;i="5.91,246,1647327600"; d="scan'208";a="548093416" Received: from labpcdell3650-001.iul.intel.com (HELO localhost) ([172.28.50.74]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 11:01:15 -0700 To: gdb-patches@sourceware.org Subject: [PATCH 1/2] gdb: Fix deleted thread when issuing next command Date: Mon, 23 May 2022 20:00:55 +0200 Message-Id: <20220523180056.1415229-2-eduard.sargsyan@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523180056.1415229-1-eduard.sargsyan@intel.com> References: <20220523180056.1415229-1-eduard.sargsyan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eduard Sargsyan via Gdb-patches Reply-To: Eduard Sargsyan Cc: Aleksandar Paunovic Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" From: Aleksandar Paunovic When issuing "next" command the thread got deleted even though it was still alive and running. This happened because the thread was examined under a wrong inferior. The fixed scenario: ~~~ $ gdb -q breakpoint-running-inferior-1-exe (gdb) set schedule-multiple off (gdb) break breakpoint-running-inferior-1.c:26 (gdb) run (gdb) add-inferior -no-connection (gdb) inferior 2 (gdb) spawn gdbserver :2346 breakpoint-running-inferior-2-exe (gdb) target remote :2346 (gdb) break breakpoint-running-inferior-2.c:26 (gdb) continue (gdb) thread 1.1 (gdb) clear breakpoint-running-inferior-2.c:26 (gdb) set schedule-multiple on (gdb) next (gdb) thread 1.1 ~~~ Before: ~~~ Thread ID 1.1 has terminated. ~~~ Now: ~~~ Switching to thread 1.1 ~~~ gdb/ChangeLog: 2021-04-30 Aleksandar Paunovic * infrun.c (keep_going_stepped_thread): Switch to correct inferior and check if thread is executing. gdb/testsuite/ChangeLog: 2021-04-30 Aleksandar Paunovic * gdb.base/breakpoint-running-inferior-1.c: New file. * gdb.base/breakpoint-running-inferior-2.c: New file. * gdb.base/breakpoint-running-inferior.exp: New file. Signed-off-by: Aleksandar Paunovic --- gdb/infrun.c | 2 + .../gdb.base/breakpoint-running-inferior-1.c | 39 +++++++++ .../gdb.base/breakpoint-running-inferior-2.c | 39 +++++++++ .../gdb.base/breakpoint-running-inferior.exp | 84 +++++++++++++++++++ 4 files changed, 164 insertions(+) create mode 100644 gdb/testsuite/gdb.base/breakpoint-running-inferior-1.c create mode 100644 gdb/testsuite/gdb.base/breakpoint-running-inferior-2.c create mode 100644 gdb/testsuite/gdb.base/breakpoint-running-inferior.exp diff --git a/gdb/infrun.c b/gdb/infrun.c index bc6521c8ec6..d794f135219 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -7499,6 +7499,8 @@ keep_going_stepped_thread (struct thread_info *tp) stepping thread is still alive. For that reason, we need to synchronously query the target now. */ + /* Make sure that we are within a correct inferior. */ + switch_to_inferior_no_thread (tp->inf); if (tp->state == THREAD_EXITED || !target_thread_alive (tp->ptid)) { infrun_debug_printf ("not resuming previously stepped thread, it has " diff --git a/gdb/testsuite/gdb.base/breakpoint-running-inferior-1.c b/gdb/testsuite/gdb.base/breakpoint-running-inferior-1.c new file mode 100644 index 00000000000..475b2c4126e --- /dev/null +++ b/gdb/testsuite/gdb.base/breakpoint-running-inferior-1.c @@ -0,0 +1,39 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2021 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include +#include + +void * +forever () +{ + /* Wait for alarm. */ + while (1) + sleep (1); /* break here */ +} + +int +main () +{ + alarm (30); + + pthread_t forever_thread; + pthread_create (&forever_thread, NULL, *forever, NULL); + pthread_join (forever_thread, NULL); + + return 0; +} diff --git a/gdb/testsuite/gdb.base/breakpoint-running-inferior-2.c b/gdb/testsuite/gdb.base/breakpoint-running-inferior-2.c new file mode 100644 index 00000000000..475b2c4126e --- /dev/null +++ b/gdb/testsuite/gdb.base/breakpoint-running-inferior-2.c @@ -0,0 +1,39 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2021 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include +#include + +void * +forever () +{ + /* Wait for alarm. */ + while (1) + sleep (1); /* break here */ +} + +int +main () +{ + alarm (30); + + pthread_t forever_thread; + pthread_create (&forever_thread, NULL, *forever, NULL); + pthread_join (forever_thread, NULL); + + return 0; +} diff --git a/gdb/testsuite/gdb.base/breakpoint-running-inferior.exp b/gdb/testsuite/gdb.base/breakpoint-running-inferior.exp new file mode 100644 index 00000000000..bb0406bc659 --- /dev/null +++ b/gdb/testsuite/gdb.base/breakpoint-running-inferior.exp @@ -0,0 +1,84 @@ +# Copyright 2021 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Create two inferiors with different targets. The first runs on top of +# a native target while the second on a remote target. Both inferiors +# use the copy of the same source code. The copy is done in order to make +# sure that a breakpoint is only in inferior 2. While in inferior 1, do +# a "next" which should break in a thread in inferior 2. +# Both executables will run total of 4 threads (2 per executable) and +# we will put a breakpoint only in the second executable to achieve this. + +load_lib gdbserver-support.exp + +standard_testfile breakpoint-running-inferior-1.c breakpoint-running-inferior-2.c +set binfile2 ${binfile}2 + +if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { + untested "failed to compile first testcase" + return -1 +} + +if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable {debug}] != "" } { + untested "failed to compile second testcase" + return -1 +} + +clean_restart ${binfile} + +gdb_test_no_output "set schedule-multiple off" + +if {![runto_main]} { + untested "failed to run to main" + return -1 +} +set break_pos [gdb_get_line_number "break here" ${srcfile}] +gdb_breakpoint "$srcfile:$break_pos" +gdb_continue_to_breakpoint "continue to breakpoint in inf 1" + +gdb_test "add-inferior -no-connection" "Added inferior 2.*" "add empty inferior 2" +gdb_test "inferior 2" "Switching to inferior 2.*" "switch to inferior 2" + +# Start gdbserver and connect. +set res [gdbserver_start "" $binfile2] +set gdbserver_protocol [lindex $res 0] +set gdbserver_gdbport [lindex $res 1] +set res [gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport] +if ![gdb_assert {$res == 0} "connect"] { + return -1 +} + +set break_pos [gdb_get_line_number "break here" ${srcfile2}] +gdb_breakpoint "$srcfile2:$break_pos" + +gdb_continue_to_breakpoint "continue to breakpoint in inf 2" + +gdb_test "thread 1.1" "Switching to thread 1.1.*" "first switch to thread 1.1" + +# Remove the breakpoint from inf 1. Now only a breakpoint in inf 2 remains. +gdb_test "clear $srcfile:$break_pos" "Deleted breakpoint 2 " "remove inf 1 breakpoint" +gdb_test_no_output "set schedule-multiple on" +gdb_test "next" ".*Thread 2.*hit Breakpoint.*" "next while in inferior 1" + +# We should be able to normally switch to thread 1.1. +# In case of a bad GDB flow the GDB was losing the thread. +gdb_test_multiple "thread 1.1" "Switching to thread 1.1" { + -re "\\\[Switching to thread 1.1 \\(Thread .*\\)\\\]" { + pass $gdb_test_name + } + -re ".*Thread ID 1.1 has terminated.*" { + fail $gdb_test_name + } +} -- 2.25.1