From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qGxwL9OQhmInIgcAWB0awg (envelope-from ) for ; Thu, 19 May 2022 14:47:47 -0400 Received: by simark.ca (Postfix, from userid 112) id BE11E1E220; Thu, 19 May 2022 14:47:47 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Wa8Z+yDZ; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 45C781E143 for ; Thu, 19 May 2022 14:47:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 233823839C45 for ; Thu, 19 May 2022 18:47:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 233823839C45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652986064; bh=iKd1fG+HHDG5B99yrpTWNQ4An3alnsIUpdDWNWwjNzU=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Wa8Z+yDZvBho4+K81WumB8MDs2JCZ2RNM7hGToaZE2cwZNxuEN3/GR+ZoNyMWwQ5Q Xal+l0R/G8P17fiBWrBQRF+qo1rSVNYl9XMcGmp5q95jUCBHMu6wwEpXRMrJgjV3LT CyMtG24/F/cajyvd3QYDJqak+3KZnkiMOyIKWMSI= Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2078.outbound.protection.outlook.com [40.107.243.78]) by sourceware.org (Postfix) with ESMTPS id 6F63B383E820 for ; Thu, 19 May 2022 18:46:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F63B383E820 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WlQ3jUN4YpEU1rF8rZQ1YBFcCMXQfwv4IbO8qW1zciSqNbQDPdSXoa1cKAOtAuT5WuQkYeOYG7CiJXjDjnDHE/dnklCuuayGHs//RjMrsX9PX47muoALPGCQkcvwlaAPENqMpdF5eq84BJ4bU+2/gOuAmVgiHvw2HuuVuO+mufuuxkibbyXsw9kVLjQn8eu6MQN7mx/yhMGjTye0LLOluSO8i+77HgbiMTsPRMKLeiXIHwsdxzO0MS797Txl72y01m+jSVmbEJ3DDNQUNaeh77Q5M6b/FcIBCLitX2IdDu30dBrfh4HKSbmkLMazAkKP+/oIYi03VwFpBelNfO6qQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iKd1fG+HHDG5B99yrpTWNQ4An3alnsIUpdDWNWwjNzU=; b=lJ365BPqSYEAdX6RO4AFHkq752kpiSnwmtLYB13xN8eI8hfBQ5ckKzq4Igbo4rxAfut5Rzk806+JCPi82h9L1Etd+NjSZXdtieJeG6ZKBKla1d4fZoS5hek+PIaVFUIDeILRDA3oNT0CuTLWU1tvpjIjUAPB9Yyt4dNc2zlt9SwrSDBDguY6P9eCg5lkb5wJdCVFSA8s8puT/BBUB75OuMvzcmmUD19JOBZ4o9gn7HjdjmRAfzTud3WZhiKCTnm0LLwMxiNZKGpKiC5Tpnvb2XRXI3Jl/WbgEmqwANo+uxR7RQ0pWVc8zucW9QbUXJgF7yYpjuUVu8maVVrO7pseOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from CO2PR05CA0006.namprd05.prod.outlook.com (2603:10b6:102:2::16) by DS7PR12MB5936.namprd12.prod.outlook.com (2603:10b6:8:7f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Thu, 19 May 2022 18:46:23 +0000 Received: from CO1NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:102:2:cafe::78) by CO2PR05CA0006.outlook.office365.com (2603:10b6:102:2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend Transport; Thu, 19 May 2022 18:46:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT016.mail.protection.outlook.com (10.13.175.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 18:46:23 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 19 May 2022 13:46:21 -0500 To: Subject: [PATCH v2 2/2] gdb: Simplify psymbol_functions::require_partial_symbols Date: Thu, 19 May 2022 19:45:57 +0100 Message-ID: <20220519184557.2169347-3-lancelot.six@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519184557.2169347-1-lancelot.six@amd.com> References: <20220519184557.2169347-1-lancelot.six@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dce9fd45-485f-4967-c60d-08da39c7df69 X-MS-TrafficTypeDiagnostic: DS7PR12MB5936:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vhue+t4IfWTJhdGT371hHHUOao/22xiM6r/YY2iO6/TdELr4CQWkyOaZ097jZYeR0SLKZPbLnqS1uVWLxAJt3jrVMuUO++wh3A6Ur+7OSQRV1JQB8bEsHozWL+G/QbERBLroHDEwQCjBY0Vg1jszHyFfF/PiU16uacQkKfC/3YnG4Sa0WtM/kf7VQnzACDqycx/sMv5yplcPAir5ZQwgDOcBNK0UVNqkHzaLGyKe9bc0wtzUNL8FakKzJ+1dYQdsJ9WySrJF0s223vg6y8zFTRJfw65HhrNjlMcZu+xa4RhX1Sm48Dby04j3HZSfMfqJzWJ8JP+fGC2Elja6Kt656GwLhfDKiDOGod6M+cfuNIqvkJBgD9LZX0djkFQUQuCzbQ0IeFe2NylIxAUBLZbcAW8Q5Wt9tdX6e2Jd3litGMvIw510v5a/xuJNuqlJNoh7F5mrmVz5ZT5tIiYjHucgDWDjqh6UrTvY/HHdusEI/eAm8F1PHo31lUjdmOVtW20EDQqJzslswMlnwSX7cikuw2CY8WyObEgCfWhTJkiM1adBnbyp09YvEy+9bUO4WAKvfwaa50cJ5vkc3qxEaH/HaDQEq8EvXu/HjFMp+/ieQ/u9U1acOguXD4dg5YaUSskqugnJq94HtCWCMX+pktdODQeOlFhI/+NIeH5s7djqYHZrUHLyS1QLDXRf/UNjy1Vq2ZHaLofMOeQl/L/HPAEYxg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(1076003)(4326008)(70586007)(70206006)(5660300002)(426003)(336012)(47076005)(8676002)(36860700001)(86362001)(82310400005)(2616005)(81166007)(4744005)(8936002)(2906002)(16526019)(186003)(26005)(7696005)(356005)(54906003)(316002)(36756003)(83380400001)(508600001)(6666004)(40460700003)(6916009)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 18:46:23.3997 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dce9fd45-485f-4967-c60d-08da39c7df69 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5936 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: lsix@lancelotsix.com, Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" The previous patch ensured that partial symbols are read before calling most of the quick_function's methods. The psymbol_functions class has the require_partial_symbols method which serves this exact purpose. This method does not need to try to read partial symbols anymore, but it can instead assert that any partial symbol have been read at this point. Regression tested on x86_64-linux. --- gdb/psymtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/psymtab.c b/gdb/psymtab.c index 402d6085fe6..2bf6cbc5848 100644 --- a/gdb/psymtab.c +++ b/gdb/psymtab.c @@ -84,7 +84,7 @@ psymtab_storage::install_psymtab (partial_symtab *pst) psymtab_storage::partial_symtab_range psymbol_functions::require_partial_symbols (struct objfile *objfile) { - objfile->require_partial_symbols (true); + gdb_assert ((objfile->flags & OBJF_PSYMTABS_READ) != 0); return m_partial_symtabs->range (); } -- 2.25.1