From: Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: JiniSusan.George@amd.com, aburgess@redhat.com
Subject: [PATCH 08/18] testsuite, fortran: make print-formatted.exp more robust
Date: Tue, 10 May 2022 16:24:27 +0200 [thread overview]
Message-ID: <20220510142437.1397399-9-nils-christian.kempke@intel.com> (raw)
In-Reply-To: <20220510142437.1397399-1-nils-christian.kempke@intel.com>
The test was written in a way that assumed, that going to main and
issuing a single next command would automatically end up after the
assign statement for ii. This was true for gfortran and ifort, but not
for ifx leading to a failed test. For ifx, GDB actually was at
the assign statment (not past it) and printing 'ii' there would lead to
GDB displaying it as 0 (instead of 10), failing the test.
I changed this to become more robust and added a line past the
assignment with a comment, as is commonly done all over the testsuite.
After this change the test passes for all, gfortran/ifort/ifx/flang.
---
gdb/testsuite/gdb.fortran/print-formatted.exp | 3 ++-
gdb/testsuite/gdb.fortran/print-formatted.f90 | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.fortran/print-formatted.exp b/gdb/testsuite/gdb.fortran/print-formatted.exp
index eaeca1ede2..59b7148852 100644
--- a/gdb/testsuite/gdb.fortran/print-formatted.exp
+++ b/gdb/testsuite/gdb.fortran/print-formatted.exp
@@ -29,7 +29,8 @@ if { ![fortran_runto_main] } {
return -1
}
-gdb_test "next" ".*" "go to the end of the program"
+gdb_breakpoint [gdb_get_line_number "End of program"]
+gdb_continue_to_breakpoint "End of program" ".*End of program.*"
gdb_test "set output-radix 16" \
"Output radix now set to decimal 16, hex 10, octal 20." \
diff --git a/gdb/testsuite/gdb.fortran/print-formatted.f90 b/gdb/testsuite/gdb.fortran/print-formatted.f90
index 63048032b1..f37fdafe97 100644
--- a/gdb/testsuite/gdb.fortran/print-formatted.f90
+++ b/gdb/testsuite/gdb.fortran/print-formatted.f90
@@ -17,4 +17,5 @@ program printformatted
integer :: ii
ii = 10
+ print *, ii ! End of program.
end program printformatted
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-05-10 14:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 14:24 [PATCH 00/18] Fortran compiler identification and ifx testsuite support Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 01/18] gdb/testsuite: remove F77_FOR_TARGET support Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 02/18] gdb/testsuite: Use -module option for Intel Fortran compilers Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 03/18] gdb/testsuite: Fix fortran types for Intel compilers Nils-Christian Kempke via Gdb-patches
2022-05-11 9:49 ` Andrew Burgess via Gdb-patches
2022-05-11 9:57 ` Kempke, Nils-Christian via Gdb-patches
2022-05-10 14:24 ` [PATCH 04/18] gdb/testsuite: add local variable for passing 'getting_compiler_info' to gdb_compile Nils-Christian Kempke via Gdb-patches
2022-05-11 10:10 ` Andrew Burgess via Gdb-patches
2022-05-11 14:24 ` Kempke, Nils-Christian via Gdb-patches
2022-05-10 14:24 ` [PATCH 05/18] gdb/testsuite: add Fortran compiler identification to GDB Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 06/18] gdb/testsuite: rename intel next gen c/cpp compilers Nils-Christian Kempke via Gdb-patches
2022-05-11 11:23 ` Andrew Burgess via Gdb-patches
2022-05-11 14:28 ` Kempke, Nils-Christian via Gdb-patches
2022-05-10 14:24 ` [PATCH 07/18] gdb/testsuite: disable charset.exp for intel compilers Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` Nils-Christian Kempke via Gdb-patches [this message]
2022-05-11 11:32 ` [PATCH 08/18] testsuite, fortran: make print-formatted.exp more robust Andrew Burgess via Gdb-patches
2022-05-11 14:32 ` Kempke, Nils-Christian via Gdb-patches
2022-05-10 14:24 ` [PATCH 09/18] testsuite, fortran: add required external keyword Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 10/18] testsuite, fortran: add compiler dependent types to dynamic-ptype-whatis Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 11/18] testsuite, fortran: Add '-debug-parameters all' when compiling with ifx Nils-Christian Kempke via Gdb-patches
2022-05-11 11:56 ` Andrew Burgess via Gdb-patches
2022-05-11 14:36 ` Kempke, Nils-Christian via Gdb-patches
2022-05-10 14:24 ` [PATCH 12/18] testsuite/lib: add check_optional_entry for GDBInfoSymbols Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 13/18] testsuite, fortran: fix info-types for intel compilers Nils-Christian Kempke via Gdb-patches
2022-05-11 12:06 ` Andrew Burgess via Gdb-patches
2022-05-11 15:20 ` Kempke, Nils-Christian via Gdb-patches
2022-05-11 16:43 ` Kempke, Nils-Christian via Gdb-patches
2022-05-30 10:33 ` Andrew Burgess via Gdb-patches
2022-05-30 10:32 ` Andrew Burgess via Gdb-patches
2022-05-10 14:24 ` [PATCH 14/18] testsuite, fortran: Add type info of formal parameter for Intel compilers Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 15/18] testsuite, fortran: allow additional completions in module.exp Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 16/18] gdb, testsuite, fortran: fix double free in mixed-lang-stack.exp Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 17/18] gdb, testsuite, fortran: fixup mixed-lang-stack for Intel/LLVM compilers Nils-Christian Kempke via Gdb-patches
2022-05-10 14:24 ` [PATCH 18/18] gdb/testsuite: fixup common-block.exp for intel compilers Nils-Christian Kempke via Gdb-patches
2022-05-11 13:29 ` Andrew Burgess via Gdb-patches
2022-05-11 15:31 ` Kempke, Nils-Christian via Gdb-patches
2022-05-16 6:36 ` George, Jini Susan via Gdb-patches
2022-05-16 7:59 ` Kempke, Nils-Christian via Gdb-patches
2022-05-11 13:32 ` [PATCH 00/18] Fortran compiler identification and ifx testsuite support Andrew Burgess via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510142437.1397399-9-nils-christian.kempke@intel.com \
--to=gdb-patches@sourceware.org \
--cc=JiniSusan.George@amd.com \
--cc=aburgess@redhat.com \
--cc=nils-christian.kempke@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox