From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][PATCH] Update syscalls/{ppc64,ppc}-linux.xml
Date: Tue, 10 May 2022 11:02:43 -0700 [thread overview]
Message-ID: <20220510110243.74851f92@f35-zws-1> (raw)
In-Reply-To: <eaa881c1-08d7-a4fb-53cb-e721377dd628@suse.de>
On Tue, 10 May 2022 11:01:27 +0200
Tom de Vries <tdevries@suse.de> wrote:
> On 5/9/22 17:48, Tom de Vries wrote:
> > Hi,
> >
> > Regenerate syscalls/{ppc64,ppc}-linux.xml on a system with 5.14 kernel.
> >
> > Note btw that it does not only add, but also renumbers, f.i.:
> > ...
> > - <syscall name="unlinkat" number="286"/>
> > + <syscall name="unlinkat" number="292"/>
> > ...
> >
> > Currently testing.
> >
>
> Here's a v2, with a gdb.base/catch-syscall.exp test-case fix included.
>
> Testing on ppc64le revealed:
> ...
> (gdb) catch syscall 286^M
> Catchpoint 2 (syscall 'openat' [286])^M
> (gdb) FAIL: gdb.base/catch-syscall.exp: multiple targets: insert catch
> syscall on syscall 286\
> -- unlinkat on powerpc:common64
> ...
>
> FWIW, I've wrote a patch that exposes the same problem on x86_64-linux (
> https://sourceware.org/pipermail/gdb-patches/2022-May/188881.html ).
>
> Any comments?
I don't have a problem with your patch, which (mostly) updates system call
numbers.
What I am wondering about is how often they change? Also, what happens
when a GDB with some set of syscall numbers is used with a kernel which
uses different numbers? (Nothing good, I'd guess.) I'm just wondering
if there's a better way to do things...
Kevin
next prev parent reply other threads:[~2022-05-10 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 15:48 Tom de Vries via Gdb-patches
2022-05-10 9:01 ` Tom de Vries via Gdb-patches
2022-05-10 18:02 ` Kevin Buettner via Gdb-patches [this message]
2022-05-10 19:19 ` will schmidt via Gdb-patches
2022-05-11 7:22 ` Tom de Vries via Gdb-patches
2022-05-10 18:32 ` Carl Love via Gdb-patches
2022-05-10 20:18 ` PATCH] " Carl Love via Gdb-patches
2022-05-11 7:45 ` Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510110243.74851f92@f35-zws-1 \
--to=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox